From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752728AbbIPS5U (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Sep 2015 14:57:20 -0400
Received: from mout.web.de ([212.227.15.4]:49166 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752002AbbIPS5S (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Sep 2015 14:57:18 -0400
Subject: Re: [PATCH v2] coccinelle: tests: unsigned value cannot be lesser
 than zero
To: Andrzej Hajda <a.hajda@samsung.com>
References: <alpine.DEB.2.10.1509161125370.2429@hadrien>
 <1442409749-32700-1-git-send-email-a.hajda@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Joe Perches <joe@perches.com>, Gilles Muller <Gilles.Muller@lip6.fr>,
        Michal Marek <mmarek@suse.com>, Nicolas Palix <nicolas.palix@imag.fr>,
        cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <55F9BB79.20203@users.sourceforge.net>
Date: Wed, 16 Sep 2015 20:56:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1442409749-32700-1-git-send-email-a.hajda@samsung.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:FovMVi8WfuxU12m8KNBwJcn+uttgNq62cBCTYf6H4fAh7YdHsw3
 zCTpbwwHZaEQ6wAJ7H6oHqVJ6+uW6NJOwwEELzxjuAQNXwfF7fnlgihoJMp+yL2VIXBhFt4
 lBNTpXrjzv1a2bB2Ng0w//6dxIWuZDr8Gq0Tb7Ay4pk4ap/fnmj2tD12wGJyPAwq9YdQl3S
 D7rotkfF+GKAjVyFxHpyw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:b4TrNkitqYE=:9yyuuex6KQR/NG5VeDBTuD
 EW1/B2hPW93xRw3+FIVCGoF+CcK4lCZQMPrc+5pM4ZQeZZPiwQEucf/PbPWY8cVJohZwLoSCV
 focatzBCHZBvq2EFfdsLKc0zrCs4UKo/E5VMxotEs27jx58AL/6QHD3wx4c7RveMlnc9V658l
 7GRY006mcDujZgQkzBTq38kGRPU+F0+ma8+HJ0gAkL4nqHBonAYF9GfuN65rBar366NqRb4CE
 dlwbHx+4bwPlCEsDQj48dgsk3zXaOy4tuDub05L2Sa2RU/yvBu+HACW3dVJsGPUyRtdoEMKg+
 SBGdnqNHDHI487WW3tIGbayLmDC/C8J4pwT8DMwnPUmSaQl6PHSAoV8iG7WCjTLVeBLEm3ROt
 H6kFbocD/OhBbWEqgWlHK+eLDe+sUi4NM6Es7EJIcTrEEOM7vCJxuERac18A4orfExZyuuIZB
 TILW3SJLuP4w9b/V0ElG3Jg2G1sCXS7Meg7YPifLibdIbyZmNvFrCnWW6yF4SB8A1INtCqeJO
 k8NNvwFsvVAKAjVjbCwg05PuF5kXbGQsnAUefxo4JXceETEjz6ZHAKsiq4A2JVIbE4NLt7Gox
 xHtRTf1qJKrBzocg4ubeSR+R+qJmGI+gMXr6RJ9S4tED5C5sKlmGjDXDCltHdGx7G+/YrQVyk
 SsPzXJD14HXWkOzKlLgfV51stBScBHZH8L+FszTVnFziND5fCkZhrUlBbqlXdGQ5PKCjL2YtB
 8qk5Q2tUVKJwcOAxqxa5ahZb75AH2uRN20zX+A==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> As we discussed earlier I have dropped idea of adding v <= 0 as it is widely
> used in checking ranges, counters, quantities.

I find that such a design decision will need more fine-tuning of the suggested
small SmPL script.


> +@r depends on context || org || report@
> +position p;
> +typedef u8, u16, u32, u64;
> +{unsigned char, unsigned short int, unsigned int, unsigned long, unsigned long long, size_t, u8, u16, u32, u64} v;

Is it eventually needed to mention the key word "int" also together with the "long" data types?


> +@@
> +
> +(
> +*v@p < 0
> +|
> +*v@p >= 0
> +)

How do you think about to split this SmPL rule so that corresponding warning
messages will really fit?

Regards,
Markus