From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753657AbbIQJjJ (ORCPT ); Thu, 17 Sep 2015 05:39:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48838 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753156AbbIQJjD (ORCPT ); Thu, 17 Sep 2015 05:39:03 -0400 Subject: Re: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' To: "Wu, Feng" , "alex.williamson@redhat.com" , "joro@8bytes.org" , "mtosatti@redhat.com" References: <1442393409-2623-1-git-send-email-feng.wu@intel.com> <1442393409-2623-10-git-send-email-feng.wu@intel.com> <55F935E9.6070707@redhat.com> Cc: "eric.auger@linaro.org" , "kvm@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" From: Paolo Bonzini Message-ID: <55FA8A29.7030905@redhat.com> Date: Thu, 17 Sep 2015 11:38:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/09/2015 03:51, Wu, Feng wrote: > > >> -----Original Message----- >> From: Paolo Bonzini [mailto:pbonzini@redhat.com] >> Sent: Wednesday, September 16, 2015 5:27 PM >> To: Wu, Feng; alex.williamson@redhat.com; joro@8bytes.org; >> mtosatti@redhat.com >> Cc: eric.auger@linaro.org; kvm@vger.kernel.org; >> iommu@lists.linux-foundation.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct >> kvm_kernel_irqfd' >> >> >> >> On 16/09/2015 10:50, Feng Wu wrote: >>> +int kvm_arch_update_irqfd_routing(struct kvm *kvm, unsigned int host_irq, >>> + uint32_t guest_irq, bool set) >>> +{ >>> + return !kvm_x86_ops->update_pi_irte ? -EINVAL : >>> + kvm_x86_ops->update_pi_irte(kvm, host_irq, guest_irq, set); >>> +} >>> + >> >> Just use "if" here. No need to resend if this is the only comment. > > I am sorry, I don't quite understand. Do you mean I don't need to include > this patch in v9? If so, what about other patches with your Reviewed-by? No, I just wrote this email first. If this was the only comment, I could have fixed it up myself. But since there were a few other comments, please send v9 with all the required changes. Thanks, Paolo