From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751940AbbIQLnF (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Sep 2015 07:43:05 -0400
Received: from mail-pa0-f46.google.com ([209.85.220.46]:33040 "EHLO
	mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751260AbbIQLnE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Sep 2015 07:43:04 -0400
Subject: Re: [PATCH V2] dummy_hcd: replace timeval with timespec64
References: <2640620.MF43KccxAS@wuerfel>
 <1442459389-11171-1-git-send-email-pingbo.wen@linaro.org>
 <20150917095906.28220.qmail@stuge.se>
Cc: linux-usb@vger.kernel.org, Y2038 <y2038@lists.linaro.org>,
        linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
        Felipe Balbi <balbi@ti.com>
To: peter@stuge.se
From: Pingbo Wen <pingbo.wen@linaro.org>
Message-ID: <55FAA727.4070206@linaro.org>
Date: Thu, 17 Sep 2015 19:42:31 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20150917095906.28220.qmail@stuge.se>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Thursday, September 17, 2015 05:59 PM, Peter Stuge wrote:
> WEN Pingbo wrote:
>> +++ b/drivers/usb/gadget/udc/dummy_hcd.c
>> @@ -833,10 +833,10 @@ static const struct usb_ep_ops dummy_ep_ops = {
>>  /* there are both host and device side versions of this call ... */
>>  static int dummy_g_get_frame(struct usb_gadget *_gadget)
>>  {
>> -	struct timeval	tv;
>> +	struct timespec64 tv;
> 
> tv is very often used for timeval structs.
> 
> I suggest also changing the variable name, for example to ts, to
> avoid some possible confusion.
> 

Hi Peter,

Thanks for pointing it out, I will fix it in next version.

Pingbo