From: Xinwei Kong <kong.kongxinwei@hisilicon.com>
To: Archit Taneja <architt@codeaurora.org>, <lars@metafoo.de>,
<treding@nvidia.com>
Cc: Rob Herring <robh@kernel.org>, <airlied@linux.ie>,
<corbet@lwn.net>, <catalin.marinas@arm.com>,
<will.deacon@arm.com>, <dri-devel@lists.freedesktop.org>,
<linux-doc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <linuxarm@huawei.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<xinliang.liu@linaro.org>, <andy.green@linaro.org>,
<qijiwen@hisilicon.com>, <gongyu@hisilicon.com>,
<haojian.zhuang@linaro.org>, <liguozhu@hisilicon.com>,
<xuwei5@hisilicon.com>, <yinshengbao@hisilicon.com>,
<yanhaifeng@hisilicon.com>, <ml.yang@hisilicon.com>,
<yimin@huawei.com>, <w.f@huawei.com>, <puck.chen@hisilicon.com>,
<bintian.wang@huawei.com>, <benjamin.gaignard@linaro.org>,
<xuyiping@hisilicon.com>, <james.yanglong@hisilicon.com>,
<fangdechun@hisilicon.com>, <linux-arm-msm@vger.kernel.org>,
<laurent.pinchart@ideasonboard.com>,
<srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH RFC 1/8] dt-bindings: Document the hi6220 bindings for DRM driver
Date: Thu, 17 Sep 2015 20:14:14 +0800 [thread overview]
Message-ID: <55FAAE96.1090801@hisilicon.com> (raw)
In-Reply-To: <55F9321E.7090100@codeaurora.org>
hi architt
On 2015/9/16 17:10, Archit Taneja wrote:
> Hi,
>
> On 09/16/2015 02:04 PM, Xinwei Kong wrote:
>> hi architt
>>
>> On 2015/9/16 2:11, Rob Herring wrote:
>>> On 09/15/2015 04:37 AM, Xinwei Kong wrote:
>>>> This adds documentation of device tree bindings for the
>>>> Graphics Processing Unit of hi6220 SOC.
>>>>
>>>> Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
>>>> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
>>>> Signed-off-by: Andy Green <andy.green@linaro.org>
>>>> Signed-off-by: Jiwen Qi <qijiwen@hisilicon.com>
>>>> Signed-off-by: Yu Gong <gongyu@hisilicon.com>
>>>> ---
>>>> .../devicetree/bindings/gpu/hisilicon,hi6220.txt | 69 ++++++++++++++++++++++
>>>> 1 file changed, 69 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/gpu/hisilicon,hi6220.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/gpu/hisilicon,hi6220.txt b/Documentation/devicetree/bindings/gpu/hisilicon,hi6220.txt
>>>> new file mode 100644
>>>> index 0000000..173ac63
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/gpu/hisilicon,hi6220.txt
>>>> @@ -0,0 +1,69 @@
>>>> + * Hisilicon hi6220 Graphics Processing Unit for HiKey board
>>>> +
>>>> + ** display-subsystem: Master device for binding DRM sub-components
>>>
>>> DRM is a Linuxism that doesn't belong in the binding.
>>>
>>>> + This master device is parent node and it will be responsible to bind all
>>>> + sub-components devices node.
>>>
>>> Are these nodes a single block in the h/w? If not, you should describe
>>> the connection of sub-nodes with of-graph instead.
>>>
>>>> + - Required properties :
>>>> + - compatible: "hisilicon,display-subsystem".
>>>> + - #address-cells, #size-cells: Must be present if the device has sub-nodes.
>>>> + - ranges: to allow probing of subdevices.
>>>> + - dma-coherent: Present if dma operations are coherent.
>>>> +
>>>> + ** ade: Graphic overlay, Graphic post-processing, display timing control.
>>>> + This device is child node of display-subsystem
>>>> + - Required properties :
>>>> + - compatible: "hisilicon,hi6220-ade".
>>>> + - reg: physical base address of the ADE register and length of memory
>>>> + region.
>>>> + - reg-names: Should contain the reg names "ade_base" and "media_base".
>>>> + - interrupt: The interrupt number to the cpu. Defines the interrupt
>>>> + by ADE.
>>>> + - clocks: The clocks needed by the ADE module.
>>>> + - clock-names: the name of the clocks.
>>>> +
>>>> + ** dsi: support mipi dsi interface
>>>> + This device is child node of display-subsystem
>>>> + - Required properties :
>>>> + - compatible: "hisilicon,hi6220-dsi".
>>>> + - reg: physical base address of the DSI register and length of memory
>>>> + region.
>>>> + - clocks: The clocks needed by the DSI module.
>>>> + - clock-names: the name of the clocks.
>>>> + - encoder-slave: phandles to a 'encoder-slave' subnode which DSI connect
>>>> + ADV7533 in order to support hdmi display.
>>>
>>> What the ADV7533 binding looks like is still being discussed.
>>> "encoder-slave" is certainly DRM specific and not how it should be done.
>>> Most likely, this needs to use the of-graph ports.
>>>
>> I dont how to implement the encoder bridge stuff in upstream,
>> you think that I will how to handle this part?
>
> You can use of-graph ports to link the dsi output with the adv7533
> bridge.
>
> An example of the binding looks like:
>
> Documentation/devicetree/bindings/drm/msm/dsi.txt
>
> The implementation of this on the dsi host side of drm/msm
> can be found in dsi_host_parse_dt, in:
>
> drivers/gpu/drm/msm/dsi/dsi_host.c
>
> You can get to know more about of-graph parsing here:
>
> Documentation/devicetree/bindings/graph.txt
>
I study your patch about of-graph parsing, I know that how to parse this
dts endpoint node. Then i dont kow how to use this device_node (which is
get by "of_graph_get_remote_port_parent" function.) to hook adv7533 operation.
can you give me some help to how to use the adv7533 interface by device_node or
other way to use adv7533?
> I'd started going through the drm/hisil patches. I'll
> share more comments there.
>
> Thanks,
> Archit
>
>>
>> Thank you
>> xinwei
>>
>>> Also, the ADV7533 connection is specific to HiKey. This binding should
>>> just generically describe how any bridge or panel is connected.
>>>
>>> Rob
>>>
>>> .
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
next prev parent reply other threads:[~2015-09-17 12:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 9:37 [PATCH RFC 0/8] Add New DRM Driver for Hisilicon's Hi6220 SoC Xinwei Kong
2015-09-15 9:37 ` [PATCH RFC 1/8] dt-bindings: Document the hi6220 bindings for DRM driver Xinwei Kong
2015-09-15 18:11 ` Rob Herring
2015-09-16 8:34 ` Xinwei Kong
2015-09-16 9:10 ` Archit Taneja
2015-09-17 12:14 ` Xinwei Kong [this message]
2015-09-15 9:37 ` [PATCH RFC 2/8] drm: hisilicon: Add new DRM driver for hisilicon Soc Xinwei Kong
2015-09-17 11:13 ` Archit Taneja
2015-09-15 9:37 ` [PATCH RFC 3/8] drm: hisilicon: Add the link to DRM/KMS interface Xinwei Kong
2015-09-15 9:37 ` [PATCH RFC 4/8] drm: hisilicon: fill interface function of plane\crtc part Xinwei Kong
2015-09-15 9:37 ` [PATCH RFC 5/8] drm: hisilicon: fill interface function of encoder\connector part Xinwei Kong
2015-09-17 11:39 ` Archit Taneja
2015-09-15 9:37 ` [PATCH RFC 6/8] drm: hisilicon: Add support for fbdev Xinwei Kong
2015-09-15 18:25 ` Rob Herring
2015-09-16 3:32 ` Xinwei Kong
[not found] ` <CAGd==05f+XVg4ZSDihftjB2wcOGkAou=AxXYXB+1=ckM2J6EBQ@mail.gmail.com>
2015-09-17 11:52 ` Rob Clark
2015-09-15 9:37 ` [PATCH RFC 7/8] drm: hisilicon: Add support for vblank Xinwei Kong
2015-09-15 9:37 ` [PATCH RFC 8/8] dts: hisilicon: Add drm driver device dts config for HiKey board Xinwei Kong
2015-09-16 15:23 ` [PATCH RFC 0/8] Add New DRM Driver for Hisilicon's Hi6220 SoC Daniel Stone
2015-09-16 20:16 ` Daniel Vetter
[not found] ` <CAGd==05NKAjH=hD=bqKNh052ff=osJ4WxwOdDb3xoC1Mgy6Jdg@mail.gmail.com>
2015-09-22 8:49 ` Daniel Vetter
2015-09-18 10:32 ` Xinwei Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FAAE96.1090801@hisilicon.com \
--to=kong.kongxinwei@hisilicon.com \
--cc=airlied@linux.ie \
--cc=andy.green@linaro.org \
--cc=architt@codeaurora.org \
--cc=benjamin.gaignard@linaro.org \
--cc=bintian.wang@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fangdechun@hisilicon.com \
--cc=gongyu@hisilicon.com \
--cc=haojian.zhuang@linaro.org \
--cc=james.yanglong@hisilicon.com \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=ml.yang@hisilicon.com \
--cc=puck.chen@hisilicon.com \
--cc=qijiwen@hisilicon.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=treding@nvidia.com \
--cc=w.f@huawei.com \
--cc=will.deacon@arm.com \
--cc=xinliang.liu@linaro.org \
--cc=xuwei5@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=yanhaifeng@hisilicon.com \
--cc=yimin@huawei.com \
--cc=yinshengbao@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).