From: Caesar Wang <caesar.upstream@gmail.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
devicetree@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add the needed timer for rk3368 SoC
Date: Fri, 18 Sep 2015 09:16:53 +0800 [thread overview]
Message-ID: <55FB6605.80601@gmail.com> (raw)
In-Reply-To: <10188118.z6mI84Cd5Z@diego>
在 2015年09月18日 03:01, Heiko Stübner 写道:
> Am Donnerstag, 17. September 2015, 15:51:12 schrieb Caesar Wang:
>> There is a need of a broadcast timer in this case to ensure proper
>> wakeup when the cpus are in sleep mode and a timer expires.
>>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>> ---
>>
>> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3368.dtsi index a712bea..99edbaa 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
>> @@ -214,6 +214,12 @@
>> (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
>> };
>>
>> + timer@ff810000 {
>> + compatible = "rockchip,rk3288-timer";
> you probably want a
> compatible = "rockchip,rk3368-timer", "rockchip,rk3288-timer";
Done.
More consideration for the future.
Although the "rk3288-timer" is working for 3368, agreed to add the
'rk3368-timer' for the rk3368-spec timer in the future.
>
>> + reg = <0x0 0xff810000 0x0 0x20>;
>> + interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>> +
>> xin24m: oscillator {
>> compatible = "fixed-clock";
>> clock-frequency = <24000000>;
>
>
>
>
> --
> Thanks,
> Caesar
prev parent reply other threads:[~2015-09-18 1:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 7:51 [PATCH 0/3] Support the timer on RK3368 SoC Caesar Wang
2015-09-17 7:51 ` [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible Caesar Wang
2015-09-17 9:11 ` Daniel Lezcano
2015-09-17 9:28 ` Caesar Wang
2015-09-17 9:43 ` Heiko Stübner
2015-09-17 10:06 ` Daniel Lezcano
2015-09-17 10:19 ` Thomas Gleixner
2015-09-17 10:57 ` Daniel Lezcano
2015-09-17 21:13 ` Russell King - ARM Linux
2015-09-18 7:53 ` Daniel Lezcano
2015-09-17 10:19 ` Caesar Wang
2015-09-18 7:55 ` Daniel Lezcano
2015-09-18 8:22 ` Caesar Wang
2015-09-18 9:08 ` Russell King - ARM Linux
2015-09-17 7:51 ` [PATCH 2/3] arm64: Enable the timer on Rockchip architecture Caesar Wang
2015-09-17 7:51 ` [PATCH 3/3] arm64: dts: rockchip: Add the needed timer for rk3368 SoC Caesar Wang
2015-09-17 19:01 ` Heiko Stübner
2015-09-18 1:16 ` Caesar Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FB6605.80601@gmail.com \
--to=caesar.upstream@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).