From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755059AbbISQKB (ORCPT <rfc822;w@1wt.eu>);
	Sat, 19 Sep 2015 12:10:01 -0400
Received: from mail-la0-f43.google.com ([209.85.215.43]:34570 "EHLO
	mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752744AbbISQKA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 19 Sep 2015 12:10:00 -0400
Subject: Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue
To: eu@felipetonello.com, linux-usb@vger.kernel.org
References: <1442596361-404-1-git-send-email-eu@felipetonello.com>
 <1442596361-404-3-git-send-email-eu@felipetonello.com>
Cc: linux-kernel@vger.kernel.org, Peter Chen <Peter.Chen@freescale.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Felipe Balbi <balbi@ti.com>,
        Andrzej Pietrasiewicz <andrzej.p@samsung.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <55FD88D5.7090003@cogentembedded.com>
Date: Sat, 19 Sep 2015 19:09:57 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1442596361-404-3-git-send-email-eu@felipetonello.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 9/18/2015 8:12 PM, eu@felipetonello.com wrote:

> From: "Felipe F. Tonello" <eu@felipetonello.com>
>
> f_midi is not checking weather the is an error on usb_ep_queue
> request, ignoring potential problems, such as memory leaks.
>
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>   drivers/usb/gadget/function/f_midi.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
> index ad50a67..a5e446d 100644
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -543,8 +543,14 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
>   		}
>   	}
>
> -	if (req->length > 0)
> -		usb_ep_queue(ep, req, GFP_ATOMIC);
> +	if (req->length > 0) {
> +		int err;
> +
> +		err = usb_ep_queue(ep, req, GFP_ATOMIC);
> +		if (err < 0)
> +			ERROR(midi, "%s queue req: %d\n",
> +			      midi->out_ep->name, err);
> +	}
>   	else

	} else {

>   		free_ep_req(ep, req);

	}

>   }

    The lines added above show the proper kernel CodingStyle. } should be on 
the same line as *else* and {} should be used in all branches of the *if* 
statement if at least one branch has them.

MBR, Sergei