From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752417AbcF1OWh (ORCPT ); Tue, 28 Jun 2016 10:22:37 -0400 Received: from mga14.intel.com ([192.55.52.115]:64814 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752091AbcF1OWe (ORCPT ); Tue, 28 Jun 2016 10:22:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,541,1459839600"; d="scan'208";a="836651334" From: Crestez Dan Leonard To: Jonathan Cameron , linux-iio@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Daniel Baluta , Crestez Dan Leonard Subject: [PATCH] iio: Fix missing unlock on duplicate trigger Date: Tue, 28 Jun 2016 17:12:01 +0300 Message-Id: <55aace217d3212cc2662d5dd010c7e5c8c0e357d.1467123107.git.leonard.crestez@intel.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since duplicate trigger names are supposed to cause errors at probe time anyway this issue is unlikely to affect anyone. Fixes commit 2e2b6a13f5f5119c36551c1ab99b85e0ad1a2105: iio: Refuse to register triggers with duplicate names Signed-off-by: Crestez Dan Leonard --- drivers/iio/industrialio-trigger.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c index 0f03523..68466be 100644 --- a/drivers/iio/industrialio-trigger.c +++ b/drivers/iio/industrialio-trigger.c @@ -89,6 +89,7 @@ int iio_trigger_register(struct iio_trigger *trig_info) /* Add to list of available triggers held by the IIO core */ mutex_lock(&iio_trigger_list_lock); if (__iio_trigger_find_by_name(trig_info->name)) { + mutex_unlock(&iio_trigger_list_lock); pr_err("Duplicate trigger name '%s'\n", trig_info->name); ret = -EEXIST; goto error_device_del; -- 2.7.4