From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755417AbcIIWH5 (ORCPT ); Fri, 9 Sep 2016 18:07:57 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46283 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755176AbcIIWHy (ORCPT ); Fri, 9 Sep 2016 18:07:54 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org F1C936168F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=spjoshi@codeaurora.org Subject: Re: [PATCH v2 01/17] rpmsg: Enable matching devices with drivers based on DT To: Bjorn Andersson References: <1472768889-3906-1-git-send-email-bjorn.andersson@linaro.org> <1472768889-3906-2-git-send-email-bjorn.andersson@linaro.org> <20160909043012.GE405@tuxbot> Cc: Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-remoteproc-owner@vger.kernel.org From: Sarangdhar Joshi Message-ID: <55c39363-5849-3185-87bc-a84472329374@codeaurora.org> Date: Fri, 9 Sep 2016 15:07:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160909043012.GE405@tuxbot> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/2016 09:30 PM, Bjorn Andersson wrote: > On Wed 07 Sep 18:46 PDT 2016, spjoshi@codeaurora.org wrote: > >> On 2016-09-01 15:27, Bjorn Andersson wrote: >>> Make it possible to match rpmsg devices based on device tree node, in >>> addition to the id table. In some of these cases the rpmsg driver would >>> not have a id_table, so make this optional. >>> >>> Signed-off-by: Bjorn Andersson >>> --- >>> >>> Changes since v1: >>> - None >>> >>> drivers/rpmsg/virtio_rpmsg_bus.c | 10 ++++++---- >>> 1 file changed, 6 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c >>> b/drivers/rpmsg/virtio_rpmsg_bus.c >>> index 4a4374cc6a59..495fa0a282d3 100644 >>> --- a/drivers/rpmsg/virtio_rpmsg_bus.c >>> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c >>> @@ -33,6 +33,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> /** >>> * struct virtproc_info - virtual remote processor state >>> @@ -175,11 +176,12 @@ static int rpmsg_dev_match(struct device *dev, >>> struct device_driver *drv) >>> const struct rpmsg_device_id *ids = rpdrv->id_table; >>> unsigned int i; >>> >>> - for (i = 0; ids[i].name[0]; i++) >>> - if (rpmsg_id_match(rpdev, &ids[i])) >>> - return 1; >>> + if (ids) >>> + for (i = 0; ids[i].name[0]; i++) >>> + if (rpmsg_id_match(rpdev, &ids[i])) >>> + return 1; >>> >>> - return 0; >>> + return of_driver_match_device(dev, drv); >> >> Do we care falling back to acpi_driver_match_device if >> of_driver_match_device fails (something similar to what platform_match >> does)? >> > > I'm not sure how this would look in the case of ACPI, so I would prefer > if we defer that until such case arise. Makes sense. > > Regards, > Bjorn > Adding Reviewed-by tag: Reviewed-by: Sarangdhar Joshi -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project