From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752574AbdATRPz (ORCPT ); Fri, 20 Jan 2017 12:15:55 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:51718 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752069AbdATRPw (ORCPT ); Fri, 20 Jan 2017 12:15:52 -0500 Subject: Re: [PATCH 2/2] ARM: dts: exynos: Use correct mfc_pd async-bridge clock for Exynos5420 To: Krzysztof Kozlowski References: <1484864995-10679-1-git-send-email-javier@osg.samsung.com> <1484864995-10679-2-git-send-email-javier@osg.samsung.com> <20170120162846.x766u3nzblqywggj@kozik-lap> From: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Inki Dae , Andi Shyti , Shuah Khan , Marek Szyprowski , Andrzej Hajda , devicetree@vger.kernel.org, Kukjin Kim , Russell King , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org Message-ID: <55cdceb9-d768-d5a9-7bc2-d4ef26d2e5e8@osg.samsung.com> Date: Fri, 20 Jan 2017 14:15:40 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170120162846.x766u3nzblqywggj@kozik-lap> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 01/20/2017 01:28 PM, Krzysztof Kozlowski wrote: > On Thu, Jan 19, 2017 at 07:29:55PM -0300, Javier Martinez Canillas wrote: >> Commit 94aed538e032 ("ARM: dts: exynos: Add async-bridge clock to MFC >> power domain for Exynos5420") fixed an imprecise external abort error >> when the MFC registers were tried to be accessed and the needed clock >> for the asynchronous bridges were gated. >> >> But according to the Exynos5420 manual the "Gating AXI clock for MFC" >> is not CLK_ACLK333 but CLK_MFC. >> >> The end effect is the same because CLK_ACLK333 is a parent of CLK_MFC >> but the correct clock should be used instead. >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> >> arch/arm/boot/dts/exynos5420.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Is this still needed? > Not really, only if we care about correctness in the existing power domains that have their clocks defined. But as said, even currently with CLK_ACLK333 works due to the clock hierarchy. I think is less of an issue now that we prefer to mark clocks that needs to be ungated as critical instead of growing the DT ABI. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America