From: Colin Ian King <colin.king@canonical.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case.
Date: Mon, 30 Apr 2018 14:19:54 +0100 [thread overview]
Message-ID: <55d29a69-84c2-538c-553c-a0752f30ac49@canonical.com> (raw)
In-Reply-To: <20180430131908.gaah7bkt4htjibbs@linaro.org>
On 30/04/18 14:19, Manivannan Sadhasivam wrote:
> Hi Colin,
>
> On Mon, Apr 30, 2018 at 02:14:20PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is a missing break in case PIN_CONFIG_DRIVE_STRENGTH leading to
>> a fall-through to the PIN_CONFIG_SLEW_RATE case that performs different
>> checks against *arg. This looks like an unintentional missing break so
>> add in the break.
>>
>
> Yes, break has been left out by mistake. Thanks for fixing!
I've noticed another missing break, I'll send a V2.
Colin
>
>> Detected by CoverityScan, CID#1468459 ("Missing break in switch")
>>
>> Fixes: 513d7a2f7e0f ("pinctrl: actions: Add Actions S900 pinctrl driver")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Thanks,
> Mani
>
>> ---
>> drivers/pinctrl/actions/pinctrl-owl.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
>> index 928b40f71a3c..d15abb97821e 100644
>> --- a/drivers/pinctrl/actions/pinctrl-owl.c
>> +++ b/drivers/pinctrl/actions/pinctrl-owl.c
>> @@ -441,6 +441,7 @@ static int owl_group_pinconf_val2arg(const struct owl_pingroup *g,
>> default:
>> return -EINVAL;
>> }
>> + break;
>> case PIN_CONFIG_SLEW_RATE:
>> if (*arg)
>> *arg = 1;
>> --
>> 2.17.0
>>
prev parent reply other threads:[~2018-04-30 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 13:14 [PATCH][next] pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case Colin King
2018-04-30 13:19 ` Manivannan Sadhasivam
2018-04-30 13:19 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55d29a69-84c2-538c-553c-a0752f30ac49@canonical.com \
--to=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).