From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0F7C4321D for ; Wed, 15 Aug 2018 18:27:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 760F02152B for ; Wed, 15 Aug 2018 18:27:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=dd-wrt.com header.i=@dd-wrt.com header.b="XXFMWIiI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 760F02152B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=dd-wrt.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728248AbeHOVUQ (ORCPT ); Wed, 15 Aug 2018 17:20:16 -0400 Received: from webmail.newmedia-net.de ([185.84.6.166]:60709 "EHLO webmail.newmedia-net.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726123AbeHOVUP (ORCPT ); Wed, 15 Aug 2018 17:20:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dd-wrt.com; s=mikd; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=z6lfI/Er/qi+U3K0RCA8j8JEmFOCSSppTcqBz/8bTcM=; b=XXFMWIiIDWRBtPXL6s0bGWFMWz5KzcLnY/YneSRhzqAGQSphZw4xGlOZ7S7icmupkjNlRUeHL7hIvvoWW+1mPUvqx9XyXacLI4MYBl3Q3S6dHrS3+olXjrKfkdPPqhmiuG86dw4E1SOWCmwse5pernHqpNMhTbuKBg7awHCYFJA=; Subject: Re: [PATCH 4.9 000/107] 4.9.120-stable review To: Sven Joachim Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, ben.hutchings@codethink.co.uk, lkft-triage@lists.linaro.org, stable@vger.kernel.org References: <20180814171520.883143803@linuxfoundation.org> <6272e062-6cfc-0669-bebf-ebb039da051a@dd-wrt.com> <87k1orms9i.fsf@turtle.gmx.de> From: Sebastian Gottschall Message-ID: <55df6754-ce8c-520a-13f9-c610ac498173@dd-wrt.com> Date: Wed, 15 Aug 2018 20:27:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <87k1orms9i.fsf@turtle.gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Received: from [79.251.189.74] (helo=[10.88.193.131]) by webmail.newmedia-net.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1fq0VW-000793-Qd; Wed, 15 Aug 2018 20:26:59 +0200 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if i fix the other error (can be reproduced with disable smp on standard i386 build) another raises up again related to smp. to be serious. this patchset of x86 patches is absolutelly broken and put together without any care. not a simple compile test has been done sorry for beeing a little bit upset. i'm sure i will find other bugs if i go deeper arch/x86/kernel/cpu/amd.c: In function 'early_init_amd': arch/x86/kernel/cpu/amd.c:660:2: error: implicit declaration of function 'amd_get_topology_early'; did you mean 'cpu_smt_check_topology_early'? [-Werror=implicit-function-declaration]   amd_get_topology_early(c);   ^~~~~~~~~~~~~~~~~~~~~~   cpu_smt_check_topology_early Am 15.08.2018 um 19:52 schrieb Sven Joachim: > On 2018-08-15 19:01 +0200, Sebastian Gottschall wrote: > >> nother issue seen on xscale and as it affects all non SMP configured kernels >> >> >> kernel/cpu.c: In function 'boot_cpu_hotplug_init': >> kernel/cpu.c:2204:28: error: 'struct cpuhp_cpu_state' has no member >> named 'booted_once' >>   this_cpu_write(cpuhp_state.booted_once, true); > I got a different error in 4.9.120 with CONFIG_SMP unset: > > ,---- > | CC drivers/rtc/rtc-cmos.o > | In file included from drivers/rtc/rtc-cmos.c:45:0: > | ./arch/x86/include/asm/i8259.h: In function 'inb_pic': > | ./arch/x86/include/asm/i8259.h:32:24: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration] > | unsigned char value = inb(port); > | ^~~ > | ./arch/x86/include/asm/i8259.h: In function 'outb_pic': > | ./arch/x86/include/asm/i8259.h:45:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration] > | outb(value, port); > | ^~~~ > | In file included from ./include/linux/mc146818rtc.h:14:0, > | from drivers/rtc/rtc-cmos.c:49: > | ./arch/x86/include/asm/io.h: At top level: > | ./arch/x86/include/asm/io.h:277:20: warning: conflicting types for 'outb' > | static inline void out##bwl(unsigned type value, int port) \ > | ^ > | ./arch/x86/include/asm/io.h:316:1: note: in expansion of macro 'BUILDIO' > | BUILDIO(b, b, char) > | ^~~~~~~ > | ./arch/x86/include/asm/io.h:277:20: error: static declaration of 'outb' follows non-static declaration > | static inline void out##bwl(unsigned type value, int port) \ > | ^ > | ./arch/x86/include/asm/io.h:316:1: note: in expansion of macro 'BUILDIO' > | BUILDIO(b, b, char) > | ^~~~~~~ > | In file included from drivers/rtc/rtc-cmos.c:45:0: > | ./arch/x86/include/asm/i8259.h:45:2: note: previous implicit declaration of 'outb' was here > | outb(value, port); > | ^~~~ > | In file included from ./include/linux/mc146818rtc.h:14:0, > | from drivers/rtc/rtc-cmos.c:49: > | ./arch/x86/include/asm/io.h:283:29: error: conflicting types for 'inb' > | static inline unsigned type in##bwl(int port) \ > | ^ > | ./arch/x86/include/asm/io.h:316:1: note: in expansion of macro 'BUILDIO' > | BUILDIO(b, b, char) > | ^~~~~~~ > | In file included from drivers/rtc/rtc-cmos.c:45:0: > | ./arch/x86/include/asm/i8259.h:32:24: note: previous implicit declaration of 'inb' was here > | unsigned char value = inb(port); > `---- > > Cheers, > Sven >