From: Helen Koike <helen.koike@collabora.com>
To: "André Almeida" <andrealmeid@collabora.com>, linux-media@vger.kernel.org
Cc: mchehab@kernel.org, hverkuil@xs4all.nl, lucmaga@gmail.com,
linux-kernel@vger.kernel.org, kernel@collabora.com,
lkcamp@lists.libreplanetbr.org
Subject: Re: [PATCH v2 09/15] media: vimc: cap: Allocate and verify mplanar buffers
Date: Fri, 12 Apr 2019 19:49:46 -0300 [thread overview]
Message-ID: <55e606ac-1354-e31c-bfb1-2193f4ee7cb9@collabora.com> (raw)
In-Reply-To: <20190327151743.18528-10-andrealmeid@collabora.com>
On 3/27/19 12:17 PM, André Almeida wrote:
> If the driver is in multiplanar mode, fill the vb2 structures
> with the planes sizes and verify it the sizes allocated to the
> planes are enough.
>
> Signed-off-by: André Almeida <andrealmeid@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
> ---
> Change in v2:
> - Use IS_MULTIPLANAR macro
>
> drivers/media/platform/vimc/vimc-capture.c | 42 ++++++++++++++++++----
> 1 file changed, 36 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/vimc/vimc-capture.c b/drivers/media/platform/vimc/vimc-capture.c
> index c344d04ed8ea..57bc2b64b093 100644
> --- a/drivers/media/platform/vimc/vimc-capture.c
> +++ b/drivers/media/platform/vimc/vimc-capture.c
> @@ -505,12 +505,28 @@ static int vimc_cap_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers,
> struct device *alloc_devs[])
> {
> struct vimc_cap_device *vcap = vb2_get_drv_priv(vq);
> + const struct v4l2_plane_pix_format *plane_fmt =
> + vcap->format.fmt.pix_mp.plane_fmt;
> + unsigned int i;
> +
> + if (IS_MULTIPLANAR(vcap)) {
> + for (i = 0; i < *nplanes; i++)
> + if (sizes[i] < plane_fmt[i].sizeimage)
> + return -EINVAL;
> + } else if (*nplanes && sizes[0] < vcap->format.fmt.pix.sizeimage)
> + return -EINVAL;
I thought checkpatch should complain about the unbalanced braces here
but it didn't.
Helen
>
> if (*nplanes)
> - return sizes[0] < vcap->format.fmt.pix.sizeimage ? -EINVAL : 0;
> - /* We don't support multiplanes for now */
> - *nplanes = 1;
> - sizes[0] = vcap->format.fmt.pix.sizeimage;
> + return 0;
> +
> + if (IS_MULTIPLANAR(vcap)) {
> + *nplanes = vcap->format.fmt.pix_mp.num_planes;
> + for (i = 0; i < *nplanes; i++)
> + sizes[i] = plane_fmt[i].sizeimage;
> + } else {
> + *nplanes = 1;
> + sizes[0] = vcap->format.fmt.pix.sizeimage;
> + }
>
> return 0;
> }
> @@ -518,9 +534,23 @@ static int vimc_cap_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers,
> static int vimc_cap_buffer_prepare(struct vb2_buffer *vb)
> {
> struct vimc_cap_device *vcap = vb2_get_drv_priv(vb->vb2_queue);
> - unsigned long size = vcap->format.fmt.pix.sizeimage;
> + unsigned long size;
> + unsigned int i;
>
> - if (vb2_plane_size(vb, 0) < size) {
> + if (IS_MULTIPLANAR(vcap)) {
> + for (i = 0; i < vb->num_planes; i++) {
> + size = vcap->format.fmt.pix_mp.plane_fmt[i].sizeimage;
> + if (vb2_plane_size(vb, i) < size) {
> + dev_err(vcap->dev,
> + "%s: buffer too small (%lu < %lu)\n",
> + vcap->vdev.name, vb2_plane_size(vb, i),
> + size);
> +
> + return -EINVAL;
> + }
> + }
> + } else if (vb2_plane_size(vb, 0) < vcap->format.fmt.pix.sizeimage) {
> + size = vcap->format.fmt.pix.sizeimage;
> dev_err(vcap->dev, "%s: buffer too small (%lu < %lu)\n",
> vcap->vdev.name, vb2_plane_size(vb, 0), size);
> return -EINVAL;
>
next prev parent reply other threads:[~2019-04-12 22:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 15:17 [PATCH v2 00/15] media: vimc: Add support for multiplanar formats André Almeida
2019-03-27 15:17 ` [PATCH v2 01/15] media: Move sp2mp functions to v4l2-common André Almeida
2019-04-12 22:48 ` Helen Koike
2019-03-27 15:17 ` [PATCH v2 02/15] media: vimc: Remove unnecessary stream checks André Almeida
2019-04-12 22:48 ` Helen Koike
2019-03-27 15:17 ` [PATCH v2 03/15] media: vimc: cap: Change vimc_cap_device.format type André Almeida
2019-04-12 22:48 ` Helen Koike
2019-03-27 15:17 ` [PATCH v2 04/15] media: vimc: cap: Dynamically define stream pixelformat André Almeida
2019-04-12 22:48 ` Helen Koike
2019-03-27 15:17 ` [PATCH v2 05/15] media: vimc: cap: Add handler for singleplanar fmt ioctls André Almeida
2019-04-12 22:48 ` Helen Koike
2019-03-27 15:17 ` [PATCH v2 06/15] media: vimc: cap: Add handler for multiplanar " André Almeida
2019-03-27 15:17 ` [PATCH v2 07/15] media: vimc: cap: Add multiplanar formats André Almeida
2019-04-12 22:49 ` Helen Koike
2019-03-27 15:17 ` [PATCH v2 08/15] media: vimc: cap: Add multiplanar default format André Almeida
2019-04-12 22:49 ` Helen Koike
2019-03-27 15:17 ` [PATCH v2 09/15] media: vimc: cap: Allocate and verify mplanar buffers André Almeida
2019-04-12 22:49 ` Helen Koike [this message]
2019-03-27 15:17 ` [PATCH v2 10/15] media: vimc: Propagate multiplanar state in the stream André Almeida
2019-04-12 22:50 ` Helen Koike
2019-03-27 15:17 ` [PATCH v2 11/15] media: vimc: Add and use new struct vimc_frame André Almeida
2019-04-16 15:17 ` Helen Koike
2019-03-27 15:17 ` [PATCH v2 12/15] media: vimc: sen: Add support for multiplanar formats André Almeida
2019-03-27 15:17 ` [PATCH v2 13/15] media: vimc: sca: " André Almeida
2019-03-27 15:17 ` [PATCH v2 14/15] media: vimc: cap: " André Almeida
2019-03-27 15:17 ` [PATCH v2 15/15] media: vimc: Create multiplanar parameter André Almeida
2019-04-12 22:50 ` Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55e606ac-1354-e31c-bfb1-2193f4ee7cb9@collabora.com \
--to=helen.koike@collabora.com \
--cc=andrealmeid@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=lucmaga@gmail.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).