From: Joe Perches <joe@perches.com>
To: davidcomponentone@gmail.com, jdike@addtoit.com
Cc: richard@nod.at, anton.ivanov@cambridgegreys.com,
johannes.berg@intel.com, linux-um@lists.infradead.org,
linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH v2] Fix application of sizeof to pointer
Date: Tue, 12 Oct 2021 00:01:58 -0700 [thread overview]
Message-ID: <55fceaaa0e44585e2b8aeb4ce57d9a5248a879e7.camel@perches.com> (raw)
In-Reply-To: <17910246df3f6ea3b2ae790af543eefbcefe49a5.1634021064.git.davidcomponentone@gmail.com>
On Tue, 2021-10-12 at 14:50 +0800, davidcomponentone@gmail.com wrote:
> From: David Yang <davidcomponentone@gmail.com>
>
> The coccinelle check report:
> "./arch/um/drivers/virt-pci.c:192:20-26:
> ERROR: application of sizeof to pointer"
> Using the "sizeof(buf->data)" to fix it.
Try compiling this with W=1 or just maybe even just compiling your change.
You've now got an unused declaration of u8 *data;
> diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
[]
> @@ -187,9 +187,8 @@ static unsigned long um_pci_cfgspace_read(void *priv, unsigned int offset,
> return ~0ULL;
>
> buf = get_cpu_var(um_pci_msg_bufs);
> - data = buf->data;
>
> - memset(data, 0xff, sizeof(data));
> + memset(buf->data, 0xff, sizeof(buf->data));
> switch (size) {
> case 1:
> @@ -204,22 +203,22 @@ static unsigned long um_pci_cfgspace_read(void *priv, unsigned int offset,
> goto out;
> }
>
> - if (um_pci_send_cmd(dev, &hdr, sizeof(hdr), NULL, 0, data, 8))
> + if (um_pci_send_cmd(dev, &hdr, sizeof(hdr), NULL, 0, buf->data, 8))
> goto out;
>
> switch (size) {
> case 1:
> - ret = data[0];
> + ret = buf->data[0];
> break;
> case 2:
> - ret = le16_to_cpup((void *)data);
> + ret = le16_to_cpup((void *)buf->data);
> break;
> case 4:
> - ret = le32_to_cpup((void *)data);
> + ret = le32_to_cpup((void *)buf->data);
> break;
> #ifdef CONFIG_64BIT
> case 8:
> - ret = le64_to_cpup((void *)data);
> + ret = le64_to_cpup((void *)buf->data);
> break;
> #endif
> default:
next prev parent reply other threads:[~2021-10-12 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 6:50 [PATCH v2] Fix application of sizeof to pointer davidcomponentone
2021-10-12 7:01 ` Joe Perches [this message]
2021-10-13 0:56 davidcomponentone
2021-10-13 6:37 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55fceaaa0e44585e2b8aeb4ce57d9a5248a879e7.camel@perches.com \
--to=joe@perches.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=davidcomponentone@gmail.com \
--cc=jdike@addtoit.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).