From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934994AbeEWUWT (ORCPT ); Wed, 23 May 2018 16:22:19 -0400 Received: from ale.deltatee.com ([207.54.116.67]:59108 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934972AbeEWUWN (ORCPT ); Wed, 23 May 2018 16:22:13 -0400 To: Bjorn Helgaas Cc: Doug Meyer , kurt.schwemmer@microsemi.com, linux-pci@vger.kernel.org, linux-ntb , Bjorn Helgaas , Jon Mason , "Jiang, Dave" , Allen Hubbe , linux-kernel@vger.kernel.org, Alex Williamson References: <1526558413-23113-1-git-send-email-dmeyer@gigaio.com> <1526558413-23113-3-git-send-email-dmeyer@gigaio.com> <20180517134521.GC19955@bhelgaas-glaptop.roam.corp.google.com> <9dd68ac0-5b9e-b257-49d2-20327c2ab282@deltatee.com> <20180522215126.GA22385@bhelgaas-glaptop.roam.corp.google.com> <598f5880-22b2-bbb4-4a37-5a60bae2348b@deltatee.com> <20180523133321.GA150632@bhelgaas-glaptop.roam.corp.google.com> From: Logan Gunthorpe Message-ID: <55fd5f21-2e9c-19a9-117c-e368deaf939e@deltatee.com> Date: Wed, 23 May 2018 14:21:59 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180523133321.GA150632@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: alex.williamson@redhat.com, linux-kernel@vger.kernel.org, allenbh@gmail.com, dave.jiang@intel.com, jdmason@kudzu.us, bhelgaas@google.com, linux-ntb@googlegroups.com, linux-pci@vger.kernel.org, kurt.schwemmer@microsemi.com, dmeyer@gigaio.com, helgaas@kernel.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 2/2] NTB: PCI Quirk to Enable Switchtec NT Functionality with IOMMU On X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/05/18 07:33 AM, Bjorn Helgaas wrote: > This (and Alex's) analysis is very useful and I'd like to capture it > somehow, perhaps by expanding the poor pci_add_dma_alias() function > comment I added with f0af9593372a ("PCI: Add pci_add_dma_alias() to > abstract implementation"). > > The admonition to "call early" without any details about *how* early > or *why* it needs to be called early is not really very useful. > > If we added your analysis, it would be a great help to anybody who > reworks IOMMU groups in the future. Sure, I'll work up a patch and send it on shortly. Logan