From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756844AbbIUNfO (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 Sep 2015 09:35:14 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:37261 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756816AbbIUNfJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 Sep 2015 09:35:09 -0400
X-AuditID: cbfec7f4-f79c56d0000012ee-82-5600078b3092
Subject: Re: [PATCH v3] coccinelle: tests: unsigned value cannot be lesser than
 zero
To: SF Markus Elfring <elfring@users.sourceforge.net>
References: <alpine.DEB.2.02.1509180734350.2064@localhost6.localdomain6>
 <1442831864-25759-1-git-send-email-a.hajda@samsung.com>
 <55FFFFF4.4000007@users.sourceforge.net>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Gilles Muller <Gilles.Muller@lip6.fr>, Joe Perches <joe@perches.com>,
        Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        cocci@systeme.lip6.fr
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <56000777.6060208@samsung.com>
Date: Mon, 21 Sep 2015 15:34:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-version: 1.0
In-reply-to: <55FFFFF4.4000007@users.sourceforge.net>
Content-type: text/plain; charset=iso-8859-15
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsVy+t/xa7rd7AxhBm//yVhsnLGe1eLHptVs
	Fuc7lzNbzP55icli9v3HLBZbb0lbXN41h81iTussNotjL5czOXB6HDvWyuyxd0uWx5dV15g9
	+rasYvRYv+Uqi8ejZfdZPJpOtbN6fN4kF8ARxWWTkpqTWZZapG+XwJVxdeIspoJutorNH76z
	NDDeYeli5OSQEDCRmLp+ISOELSZx4d56ti5GLg4hgaWMEievfmWEcJ4zSsw7+pUVpEpYIEyi
	e/F8pi5GDg4RAVOJPydCIGrWMkp8bWtjAXGYBRYzSaxZ/IUNpIFNQFPi7+abYDavgJbEuyn7
	2UFsFgFVic0XT4PFRQUiJE6dfQtVIyjxY/I9sPM4gRacnPoCbBmzgK7Egg0eIGFmAXmJzWve
	Mk9gFJiFpGMWQtUsJFULGJlXMYqmliYXFCel5xrqFSfmFpfmpesl5+duYoTExJcdjIuPWR1i
	FOBgVOLhdRD4HyrEmlhWXJl7iFGCg1lJhFdnFlCINyWxsiq1KD++qDQntfgQozQHi5I479xd
	70OEBNITS1KzU1MLUotgskwcnFINjAtm8f7e9edTFzPjQqtn/lckIk5OsEwwuMA/aevnky62
	kts1f6YctGLtZNp762j4T9PPZyN+h8jXyl/4czLxyuXD/+vnlHtmH7pt63GRfSPbLR7JfSFt
	n1gyTzqFlLLqzd2z+Krzooku/Q2ZafPTWvzbrSfXvXItfPjL+eOPz14bFu9b2fQg+oQSS3FG
	oqEWc1FxIgDMKTukhQIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/21/2015 03:02 PM, SF Markus Elfring wrote:
>> v3: added bool type
> I would appreciate a bit more feedback for my concerns around your
> evolving approach.

Ups, I have missed your email.

> * Reuse of "long int"?
If you mean adding int to 'unsigned long [long]' types, it does not work.
For some reason it works only without adding int after long.

> * Splitting of the suggested SmPL rule so that each source code check
> will be connected with appropriate warning messages.

Personally I prefer one message as it is more compact and
fits quite well in both cases, but I have no strong fillings with separate
message for each case.

>
> Will any more fine-tuning be useful?
Could you elaborate it.

Regards
Andrzej

>
> Regards,
> Markus
>