From: Rob Herring <robh@kernel.org>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
JBottomley@odin.com, vinholikatti@gmail.com,
amit.daniel@samsung.com, essuuj@gmail.com,
devicetree@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH v2 01/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC
Date: Mon, 21 Sep 2015 09:33:28 -0500 [thread overview]
Message-ID: <56001538.5030706@kernel.org> (raw)
In-Reply-To: <1442483137-32376-2-git-send-email-alim.akhtar@samsung.com>
On 09/17/2015 04:45 AM, Alim Akhtar wrote:
> From: Seungwon Jeon <essuuj@gmail.com>
>
> This patch introduces Exynos UFS PHY driver. This driver
> supports to deal with phy calibration and power control
> according to UFS host driver's behavior.
>
> Signed-off-by: Seungwon Jeon <essuuj@gmail.com>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> .../devicetree/bindings/phy/samsung-phy.txt | 22 ++
It is preferred to put the binding in a separate patch.
> drivers/phy/Kconfig | 7 +
> drivers/phy/Makefile | 1 +
> drivers/phy/phy-exynos-ufs.c | 262 ++++++++++++++++++++
> drivers/phy/phy-exynos-ufs.h | 85 +++++++
> drivers/phy/phy-exynos7-ufs.h | 89 +++++++
> include/linux/phy/phy-exynos-ufs.h | 107 ++++++++
> 7 files changed, 573 insertions(+)
> create mode 100644 drivers/phy/phy-exynos-ufs.c
> create mode 100644 drivers/phy/phy-exynos-ufs.h
> create mode 100644 drivers/phy/phy-exynos7-ufs.h
> create mode 100644 include/linux/phy/phy-exynos-ufs.h
>
> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> index 60c6f2a..1abe2c4 100644
> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> @@ -174,3 +174,25 @@ Example:
> usbdrdphy0 = &usb3_phy0;
> usbdrdphy1 = &usb3_phy1;
> };
> +
> +Samsung Exynos7 soc serise UFS PHY Controller
s/serise/series/
> +---------------------------------------------
> +
> +UFS PHY nodes are defined to describe on-chip UFS Physical layer controllers.
> +Each UFS PHY controller should have its own node.
> +
> +Required properties:
> +- compatible : compatible list, contains "samsung,exynos7-ufs-phy"
> +- reg : offset and length of the UFS PHY register set;
> +- reg-names : reg name(s) must be 'phy-pma';
> +- #phy-cells : must be zero
> +- samsung,syscon-phandle : a phandle to the PMU system controller, no arguments
How about samsung,pmu-syscon as syscon can mean a variety of things?
> +
> +Example:
> + ufs_phy: ufs-phy@0x15571800 {
> + compatible = "samsung,exynos7-ufs-phy";
> + reg = <0x15571800 0x240>;
> + reg-names = "phy-pma";
> + samsung,syscon-phandle = <&pmu_system_controller>;
> + #phy-cells = <0>;
> + };
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 6b8dd16..7449376 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -358,4 +358,11 @@ config PHY_BRCMSTB_SATA
> Enable this to support the SATA3 PHY on 28nm Broadcom STB SoCs.
> Likely useful only with CONFIG_SATA_BRCMSTB enabled.
>
> +config PHY_EXYNOS_UFS
> + tristate "EXYNOS SoC series UFS PHY driver"
> + depends on OF && ARCH_EXYNOS
|| COMPILE_TEST
> + select GENERIC_PHY
> + help
> + Support for UFS PHY on Samsung EXYNOS chipsets.
> +
> endmenu
next prev parent reply other threads:[~2015-09-21 18:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 9:45 [PATCH v2 00/11] exynos-ufs: add support for Exynos Alim Akhtar
2015-09-17 9:45 ` [PATCH v2 01/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC Alim Akhtar
2015-09-21 14:33 ` Rob Herring [this message]
2015-10-01 4:32 ` Alim Akhtar
2015-09-17 9:45 ` [PATCH v2 02/11] scsi: ufs: add quirk to contain unconformable utrd field Alim Akhtar
2015-09-17 9:45 ` [PATCH v2 03/11] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar
2015-09-17 9:45 ` [PATCH v2 04/11] scsi: ufs: add quirk not to allow reset of interrupt aggregation Alim Akhtar
2015-09-17 9:45 ` [PATCH v2 05/11] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar
2015-09-17 9:45 ` [PATCH v2 06/11] scsi: ufs: add specific callback for nexus type Alim Akhtar
2015-09-17 9:45 ` [PATCH v2 07/11] scsi: ufs: add add specific callback for hibern8 Alim Akhtar
2015-09-17 9:45 ` [PATCH v2 08/11] scsi: ufs: make ufshcd_config_pwr_mode of non-static func Alim Akhtar
2015-09-17 9:45 ` [PATCH v2 09/11] scsi: ufs: return value of pwr_change_notify Alim Akhtar
2015-09-17 9:45 ` [PATCH v2 10/11] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar
2015-09-17 9:45 ` [PATCH v2 11/11] scsi: ufs: Add exynos ufs platform data Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56001538.5030706@kernel.org \
--to=robh@kernel.org \
--cc=JBottomley@odin.com \
--cc=alim.akhtar@samsung.com \
--cc=amit.daniel@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=essuuj@gmail.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).