From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756717AbbIVGgb (ORCPT ); Tue, 22 Sep 2015 02:36:31 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:61123 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756232AbbIVGg2 (ORCPT ); Tue, 22 Sep 2015 02:36:28 -0400 X-AuditID: cbfec7f5-f794b6d000001495-42-5600f6e8bff3 Message-id: <5600F6E6.8050406@samsung.com> Date: Tue, 22 Sep 2015 08:36:22 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Boris Brezillon Cc: Thierry Reding , linux-pwm@vger.kernel.org, Mark Brown , Liam Girdwood , Jingoo Han , Lee Jones , linux-fbdev@vger.kernel.org, Bryan Wu , Richard Purdie , linux-leds@vger.kernel.org, Maxime Ripard , linux-sunxi@googlegroups.com, Heiko Stuebner , linux-rockchip@lists.infradead.org, Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Doug Anderson , =?ISO-8859-1?Q?Uwe_Kleine-K=F6nig?= Subject: Re: [PATCH v3 01/12] pwm: introduce default period and polarity concepts References: <1442828009-6241-1-git-send-email-boris.brezillon@free-electrons.com> <1442828009-6241-2-git-send-email-boris.brezillon@free-electrons.com> In-reply-to: <1442828009-6241-2-git-send-email-boris.brezillon@free-electrons.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02RW0iTYRjHffcd9rkafjqtN9OkRVBGpiL4ViJ1E28XgeABqYta+qGSU9mc ZCAeSNSB54ycoZZZTWvizMxDUeo0Ecs0lnnWNL48ZLk85dSaK/Du9zz/H8//4mEIh1HSmYmK iecUMbJoKS0iuzc7jcf5ZZsQz1s//dBr/h6JiiamaGRozBegtI0ZEpU3aAWoV+eLtiZnKfT4 V7EQjS0ZAFr+mClA+i9GCr3N+UGh/qa7NKqf0wE0MlIF0OL4FoHWJzuEqF7/kkC6CV6ANHMS 1Nw0TaG1plIS1ZQN0mgovxCcgXhK/wHgXJ2Jwo2aESEu16twS34XjWd6h0msr8qi8bCxhcZ1 D5Jx7oYnbilbpXCDsZTAnQMNAmzSH8ANzY/IALuLIr9wLjoqgVOc8L8iitSMHY3rsb/O35Gk gDmxGtgykPWB62/SSCvvgb2jNbQaiBgHthLA2pIVoXX4CuCnoXzCYolZd6j/bKIsTLKHobl2 fHtPs15wjZ8VWNiJDYXm7leU1beHq4Wj2w2OLIKZE4btBoJNF8JGYwWwBBI2EPK/K/5VlwA4 XF8stAS2bBCca9duXyLY01Bb8BxY2Q3WPZkn8gCr2VGi2aFpdmjlgKgCTpwqLE55NULu7aGU yZWqmAiPsFi5Hli/vvQCVHacagUsA6S7xTjHJsSBkiUoE+WtADKE1FF8fuLvShwuS7zBKWIv K1TRnLIV7GdI6V5xcdNCkAMbIYvnrnFcHKf4nwoYW+cUcF/Kr+vcDgaGVg9OrWaY9y2+31Vg NqkfGtSG3JPsbXeJaPBsMFax0bB/K7OEb1Pe5KpdvVyW57NdzhWqDh1L8mR8gpd5X+Ca0Xxk PCDd7kLWt76id4ueyPhsJcn70lOJdDq1IM+cvdDeVtSVXKf2txuAfea0TW1Xj+NK6ncpqYyU ebkTCqXsD6q0hPfxAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 09/21/2015 11:33 AM, Boris Brezillon wrote: > When requested by a user, the PWM is assigned a default period and polarity > extracted from the DT, the platform data or statically set by the driver. > Those default values are currently stored in the period and polarity > fields of the pwm_device struct, but they will be stored somewhere else > once we have introduced the architecture allowing for hardware state > retrieval. > > The pwm_set_default_polarity and pwm_set_default_period should only be > used by PWM drivers or the PWM core infrastructure to specify the > default period and polarity values. > > PWM users might call the pwm_get_default_period to query the default > period value. There is currently no helper to query the default > polarity, but it might be added later on if there is a need for it. > > This patch also modifies all the places where the default helpers should > be used in place of the standard ones. > > Signed-off-by: Boris Brezillon > --- > drivers/leds/leds-pwm.c | 2 +- > drivers/pwm/core.c | 14 +++++++------- > drivers/pwm/pwm-pxa.c | 2 +- > drivers/pwm/pwm-sun4i.c | 3 ++- > drivers/regulator/pwm-regulator.c | 4 ++-- > drivers/video/backlight/lm3630a_bl.c | 4 ++-- > drivers/video/backlight/pwm_bl.c | 2 +- > drivers/video/fbdev/ssd1307fb.c | 2 +- > include/linux/pwm.h | 17 +++++++++++++++++ > 9 files changed, 34 insertions(+), 16 deletions(-) > > diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c > index 1d07e3e..2c564d1 100644 > --- a/drivers/leds/leds-pwm.c > +++ b/drivers/leds/leds-pwm.c > @@ -125,7 +125,7 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, > if (led_data->can_sleep) > INIT_WORK(&led_data->work, led_pwm_work); > > - led_data->period = pwm_get_period(led_data->pwm); > + led_data->period = pwm_get_default_period(led_data->pwm); > if (!led_data->period && (led->pwm_period_ns > 0)) > led_data->period = led->pwm_period_ns; > Acked-by: Jacek Anaszewski -- Best Regards, Jacek Anaszewski