From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932884AbbIVHgt (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Sep 2015 03:36:49 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:10840 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932340AbbIVHgr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Sep 2015 03:36:47 -0400
X-AuditID: cbfec7f4-f79c56d0000012ee-e6-5601050cc861
Message-id: <5601050B.1000802@samsung.com>
Date: Tue, 22 Sep 2015 09:36:43 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: linux-kernel@vger.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Richard Purdie <rpurdie@rpsys.net>, linux-leds@vger.kernel.org
Subject: Re: [PATCH 30/38] leds: flash: remove invalid check
References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com>
 <1442842450-29769-31-git-send-email-a.hajda@samsung.com>
In-reply-to: <1442842450-29769-31-git-send-email-a.hajda@samsung.com>
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t/xa7o8rIxhBn/OsFjcWneO1WLjjPWs
	Fpd3zWGz2PpmHaPF2iN32S1273rK6sDmsWf+D1aPvi2rGD0+b5ILYI7isklJzcksSy3St0vg
	yji1r4e9YDl7xbEty1gaGN+zdjFyckgImEh0tN5jgbDFJC7cW8/WxcjFISSwlFFi5doZTBDO
	M0aJibc3gXXwCmhJzN3fyQ5iswioSpydfA3MZhMwlPj54jUTiC0qECHx5/Q+qHpBiR+TITaI
	CKhLzD55hxlkKLPASUaJky/XgDUIC9hILN39A2yQkECdRFPrHjCbU8BV4tj9E2wgNrOAtcTK
	SdsYIWx5ic1r3jJPYBSYhWTHLCRls5CULWBkXsUomlqaXFCclJ5rqFecmFtcmpeul5yfu4kR
	EspfdjAuPmZ1iFGAg1GJh9ezjyFMiDWxrLgy9xCjBAezkgjv8/9AId6UxMqq1KL8+KLSnNTi
	Q4zSHCxK4rxzd70PERJITyxJzU5NLUgtgskycXBKNTCmSvzSjl8xv+f86Rhb2cf7z5w+wn7W
	XMx5upKGDU+CsOHxTQWbPBUcLmuc+v96hvfj7Yft+XjDUp3uTo3btoA9bMlK+0W8bbEcpmuZ
	29uKd3Uu3VBh8usX4w4m6z2u99W8nunVb3jmu0L0I9s/5bwW09c/tiaeniLp8W1OrHuwkg3H
	48TS2z1KLMUZiYZazEXFiQDv2aIYYQIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrzej,

On 09/21/2015 03:34 PM, Andrzej Hajda wrote:
> Unsigned cannot be lesser than zero.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>   drivers/leds/led-class-flash.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c
> index 3b25734..c209077 100644
> --- a/drivers/leds/led-class-flash.c
> +++ b/drivers/leds/led-class-flash.c
> @@ -108,7 +108,7 @@ static ssize_t flash_strobe_store(struct device *dev,
>   	if (ret)
>   		goto unlock;
>
> -	if (state < 0 || state > 1) {
> +	if (state > 1) {
>   		ret = -EINVAL;
>   		goto unlock;
>   	}
>

Merged, thanks.

-- 
Best Regards,
Jacek Anaszewski