Re: [PATCH v3] coccinelle: tests: unsigned value cannot be lesser than zero

From: Andrzej Hajda <a.hajda@samsung.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Joe Perches <joe@perches.com>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Michal Marek <mmarek@suse.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	cocci@systeme.lip6.fr
Subject: Re: [PATCH v3] coccinelle: tests: unsigned value cannot be lesser than zero
Date: Wed, 23 Sep 2015 09:34:35 +0200	[thread overview]
Message-ID: <5602560B.2000601@samsung.com> (raw)
In-Reply-To: <56017374.3080402@users.sourceforge.net>

On 09/22/2015 05:27 PM, SF Markus Elfring wrote:
>> If you mean adding int to 'unsigned long [long]' types, it does not work.
>> For some reason it works only without adding int after long.
> Do you get any error message for this SmPL approach?
> With which source files do you try the extended SmPL script out?
>
> Regards,
> Markus
>
No, spatch just does not find everything it should. Sample below:
--- test.cocci
virtual context

@r depends on context@
{unsigned char, unsigned short int, unsigned int, unsigned long int, unsigned
long long, size_t} v;
@@

*v
--- test.c
void f()
{
    unsigned long ul;
    unsigned long int uli;
    unsigned long long ull;
    unsigned long long int ulli;

    ul;
    uli;
    ull;
    ulli;
}
---
In the example above spatch finds ull, ulli, but not ul and uli.
If you add int to unsigned long long, it won't find anything.

Regards
Andrzej