From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755490AbbIWPR6 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Sep 2015 11:17:58 -0400
Received: from mout.web.de ([212.227.15.14]:62048 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751754AbbIWPR4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Sep 2015 11:17:56 -0400
Subject: Re: [PATCH v3] coccinelle: tests: unsigned value cannot be lesser
 than zero
To: Andrzej Hajda <a.hajda@samsung.com>
References: <alpine.DEB.2.02.1509180734350.2064@localhost6.localdomain6>
 <1442831864-25759-1-git-send-email-a.hajda@samsung.com>
 <55FFFFF4.4000007@users.sourceforge.net> <56000777.6060208@samsung.com>
 <56017374.3080402@users.sourceforge.net> <5602560B.2000601@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Gilles Muller <Gilles.Muller@lip6.fr>, Joe Perches <joe@perches.com>,
        Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        cocci@systeme.lip6.fr
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <5602C28F.9010302@users.sourceforge.net>
Date: Wed, 23 Sep 2015 17:17:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <5602560B.2000601@samsung.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:MNWSTOT2kSEsAbARoxQqtiklmKK8NecqYGnI7N1BErJaUmTmLCJ
 fYXjP+xPrQH8LtjW6NlI6AlShddAwVrrGL0PWqbaL++XMi6ssvK5aNL9w6KS4uZADq/3z98
 T+adqJNEnWMimoLZKGN+0EYY/fIM1MfTsmt4rAj0sXRuFUJs0QjYp+dlrqqImrqAoFQYa2q
 zyoyPVFZhx5dR+s+udIXQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:XE+mGHDm67w=:vN9XBHnouEMnmTAuIQkbS8
 CaA0kSCTboaFSp6V+AWJgyCRHamFc8F1NsKHBAsJlJ+8TJsrg5lqeEldrJ1sh8cL8IF0r25nl
 GVGXbYeyTh9p5r9qqlpzm1iIlWcgp/rvrxAAazeCiiIyR7THKyW6v3GDamhJZBvPb3q/BhMJr
 JJE0PbzuGG8J1iLJmCct2tJMDMV9l4OgmMKeRuazb43P5ts9QS0mRX9znFdK/zJfDzPhDovDL
 ToRQo6Hfg52c/3HCarFuoOLMyJU9pfs2aBnLx23aFhApFF8NoybJPx3grrIkxzBTgBAZSdvUJ
 HSJantVTYoxvbZBkf3kJyTQUZTH9XJUydFaDbHnyGf1+AOLWGz31+vyQIpsDRko8X/S7JI/YG
 T3zjzLUv7hok/ta9HT85fyoD8/whilivQmUtc2foJpUZIEtSZHPXI7FUZDa+hArK8/iMya/zU
 6uZ80yp9FJ/WTfQNxE+OAnVb6//zwYe4XRDEicjHVZhJL+X2OO/N2cUMVBpA3Dmovcij9FqFt
 CHxrFmPhtEmYeskV3M0PV5WsxepRUT5n0O8LNxMVpbSETAAmY5XZ25i6LtDxTGccmfRutc+79
 7bLv/OamMQOltm2z8/f6IdUixaBLE7/sgunuFJlCfnjuNmSZlktj/khAlyZ0BlVjrOxbgonjg
 C6mlrUhcjsTssuPWxWMCnt10x3KKpsaPQX3gpeJhm4yhzZE/zG6AldNQIRvzgHvNK6ihpUVsD
 2sG+ERjnFF9fpfdx0N4DMdeJtB4L5zeLF2oQvw==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> In the example above spatch finds ull, ulli, but not ul and uli.
> If you add int to unsigned long long, it won't find anything.

I suggest to take another look at the use of type modifiers
in the semantic patch language. It seems that it matters occasionally
to specify them explicitly.

How do you think about to reuse a SmPL script like the following?


@find_unsigned@
typedef _Bool, bool, u8, u16, u32, u64;
{
unsigned,
unsigned char,
unsigned int,
unsigned short,
unsigned short int,
unsigned long,
unsigned long int,
unsigned long long,
unsigned long long int,
size_t,
_Bool,
bool,
u8,
u16,
u32,
u64
} var;
@@
*var


Regards,
Markus