From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbbI3FW7 (ORCPT ); Wed, 30 Sep 2015 01:22:59 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:63951 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbbI3FWz (ORCPT ); Wed, 30 Sep 2015 01:22:55 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-64-560b71acfdb4 Subject: Re: [PATCH v5 03/17] drm: bridge: analogix/dp: fix some obvious code style To: Yakir Yang , Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Heiko Stuebner , Mark Yao , Thierry Reding , joe@perches.com, Rob Herring References: <1442906428-2609-1-git-send-email-ykk@rock-chips.com> <1442907276-2997-1-git-send-email-ykk@rock-chips.com> Cc: David Airlie , Russell King , djkurtz@chromium.org, dianders@chromium.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb@gmail.com, robherring2@gmail.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <560B719A.4040309@samsung.com> Date: Wed, 30 Sep 2015 14:22:34 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1442907276-2997-1-git-send-email-ykk@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUzMcRzHfX9P96v8+LqK78rGzsPmNnGy+Qyz5g++NqN5aGYjP/opVHJX yGYuMY+nqzzkEpqorpOUTThPrWVp18N6MHJXc4tSh+XKQ546Mv57fd4Pn88/H5FVn+NDxG2J yYo+UY7XCP5c3Y8nrTNtuwKiZt/smwAvSut5MNXXMlDWl89CRsNzBJeqhzXHtccCpOVc4qFl 4L0A9lYXAxl9+Tz0lxxWwc9XvTzUvy1GkNVh5qDIe14FuR1uDrpdTRz0dusgw93LQmPXSQEc B/tUUO5u46H57gUB+jt/spDT8ICB9mYJKk8/YsB87joHh+9Xq+DT4KAAzjIHgpzsHgHah8ZA vTFbFaGhtos2RA+lnxRorrGJo82nTAz9/uYZR+9YnCpaXOgVaLn1mEBvD3bytOPEE4ZWFByg pvR3AvVa21j63fKQo6duWRG93XaRjVSv918Yo8Rv263oZy3a5B+XedTJJfUE7C11e3gjuuV3 HPmJBM8ljblfVX94PGl03RCOI39Rja8ikubOGxm8iJScLuN9qUC8lrjTc1mfEYQrWHLFY2d8 hhqnkh9pA4zPYHEdT95U9/9uCDicVBQWCD6WsJbYG62/73F4Gik1mlgfB+N15KnDM5IZRz5n uzgf++HFxNVpGWZxeGkY6WjS+mQWTyIVNg9rRtjyX8PyL2X5L3UZsVYUrKRsSTJsjk3QhRnk BENKYmzYlp0J5ejPu3gr0ZWa+VUIi0gzWurGAVFqXt5tSE2oQkRkNUFSFwxLUoycuk/R74zW p8QrhioUKnKaCVLe3fdr1DhWTlZ2KEqSov/rMqJfiBHNcC7PC9ZNUqe2BIR/mLNxSmad+UPi y+jrM8OXfQtU12zVpq/sGopacz8/VLv6SM0C+4qzy0bJnrWL9zcHfXqdMW7RxMlLGg7d+2IJ Uoq3LnWumrJB2Y73SHHy1OnzOm0FgfM+SiWmgeLIzDO1tdFm2j1tSKeRpgaOvVBEsnoi4Ohk DWeIk3VaVm+QfwGSFjLPKgMAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.09.2015 16:34, Yakir Yang wrote: > Fix some obvious alignment problems, like alignment and line > over 80 characters problems, make this easy to be maintained > later. > > Signed-off-by: Yakir Yang > --- > Changes in v5: > - Resequence this patch after analogix_dp driver have been split > from exynos_dp code, and rephrase reasonable commit message, and > remove some controversial style (Krzysztof) > - analogix_dp_write_byte_to_dpcd( > - dp, DP_TEST_RESPONSE, > + analogix_dp_write_byte_to_dpcd(dp, > + DP_TEST_RESPONSE, > DP_TEST_EDID_CHECKSUM_WRITE); > > Changes in v4: None > Changes in v3: None > Changes in v2: > - Improved commit message more readable, and avoid using some > uncommon style like bellow: (Joe Preches) > - retval = exynos_dp_read_bytes_from_i2c(... > ...); > + retval = > + exynos_dp_read_bytes_from_i2c(......); > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 129 ++++++++++----------- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 72 ++++++------ > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 124 ++++++++++---------- > 3 files changed, 163 insertions(+), 162 deletions(-) > IMHO much better than in previous attempt. The code looks good: Reviewed-by: Krzysztof Kozlowski BTW my opinion is not enough, you still need an ack from Exynos DP maintainer (or DRM guys). Best regards, Krzysztof