From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbbI3OnH (ORCPT ); Wed, 30 Sep 2015 10:43:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:42401 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450AbbI3OnD (ORCPT ); Wed, 30 Sep 2015 10:43:03 -0400 Subject: Re: [PATCH 12/12] mm, page_alloc: Only enforce watermarks for order-0 allocations To: Vitaly Wool References: <1440418191-10894-1-git-send-email-mgorman@techsingularity.net> <20150824123015.GJ12432@techsingularity.net> <20150909123901.GA12432@techsingularity.net> <560BE934.3030808@suse.cz> Cc: Mel Gorman , Joonsoo Kim , Andrew Morton , Johannes Weiner , Rik van Riel , David Rientjes , Joonsoo Kim , Michal Hocko , Linux-MM , LKML From: Vlastimil Babka Message-ID: <560BF4F4.9010000@suse.cz> Date: Wed, 30 Sep 2015 16:43:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/30/2015 04:16 PM, Vitaly Wool wrote: >>>>> >>>> >>>> So what do you suggest instead? A fixed number, some other heuristic? >>>> You have pushed several times now for the series to focus on the latency >>>> of standard high-order allocations but again I will say that it is >>>> outside >>>> the scope of this series. If you want to take steps to reduce the latency >>>> of ordinary high-order allocation requests that can sleep then it should >>>> be a separate series. >>> >>> >>> I do believe https://lkml.org/lkml/2015/9/9/313 does a better job >> >> >> Does a better job regarding what exactly? It does fix the CMA-specific >> issue, but so does this patch - without affecting allocation fastpaths by >> making them update another counter. But the issues discussed here are not >> related to that CMA problem. > > Let me disagree. Guaranteeing one suitable high-order page is not > enough, so the suggested patch does not work that well for me. > Existing broken watermark calculation doesn't work for me either, as > opposed to the one with my patch applied. Both solutions are related > to the CMA issue but one does make compaction work harder and cause > bigger latencies -- why do you think these are not related? Well you didn't mention which issues you have with this patch. If you did measure bigger latencies and more compaction work, please post the numbers and details about the test.