From: Colin Ian King <colin.king@canonical.com>
To: Richard Weinberger <richard@nod.at>, Garry McNulty <garrmcnu@gmail.com>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com,
adrian.hunter@intel.com, s.hauer@pengutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ubifs: fix memory leak on error condition
Date: Thu, 15 Nov 2018 22:45:33 +0000 [thread overview]
Message-ID: <560ceae1-e9f1-26ca-e1b2-3568e38a4e28@canonical.com> (raw)
In-Reply-To: <2181429.CC2M8HkSot@blindfold>
On 15/11/2018 21:42, Richard Weinberger wrote:
> Am Donnerstag, 15. November 2018, 21:38:50 CET schrieb Garry McNulty:
>> If the call to ubifs_read_nnode() fails in ubifs_lpt_calc_hash() an
>> error is returned without freeing the memory allocated to 'buf'.
>> Jump to 'out' label to free allocated memory and return the error code.
>>
>> Detected by CoverityScan, CID 1441025 ("Resource leak")
>>
>> Signed-off-by: Garry McNulty <garrmcnu@gmail.com>
>> ---
>> fs/ubifs/lpt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ubifs/lpt.c b/fs/ubifs/lpt.c
>> index d1d5e96350dd..c162459a1e02 100644
>> --- a/fs/ubifs/lpt.c
>> +++ b/fs/ubifs/lpt.c
>> @@ -1688,7 +1688,7 @@ int ubifs_lpt_calc_hash(struct ubifs_info *c, u8 *hash)
>> if (!c->nroot) {
>> err = ubifs_read_nnode(c, NULL, 0);
>> if (err)
>> - return err;
>> + goto out;
>> }
>>
>> cnode = (struct ubifs_cnode *)c->nroot;
>
> Please see:
> http://lists.infradead.org/pipermail/linux-mtd/2018-October/085081.html
>
> If Colin won't send a v2, please do you so, then I'll take your v2.
Please take Garry's V2, sorry, I somehow overlooked doing a V2.
>
> Thanks,
> //richard
>
>
prev parent reply other threads:[~2018-11-15 22:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 20:38 [PATCH] ubifs: fix memory leak on error condition Garry McNulty
2018-11-15 21:42 ` Richard Weinberger
2018-11-15 22:45 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560ceae1-e9f1-26ca-e1b2-3568e38a4e28@canonical.com \
--to=colin.king@canonical.com \
--cc=adrian.hunter@intel.com \
--cc=dedekind1@gmail.com \
--cc=garrmcnu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).