From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752561AbbJEPRZ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 5 Oct 2015 11:17:25 -0400
Received: from smtp.citrix.com ([66.165.176.89]:42017 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751479AbbJEPRY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 5 Oct 2015 11:17:24 -0400
X-IronPort-AV: E=Sophos;i="5.17,639,1437436800"; 
   d="scan'208";a="304355426"
Subject: Re: [PATCH v3 3/9] xen/blkfront: separate per ring information out of
 device info
To: Bob Liu <bob.liu@oracle.com>
References: <1441456782-31318-1-git-send-email-bob.liu@oracle.com>
 <1441456782-31318-4-git-send-email-bob.liu@oracle.com>
 <560EB88A.9070905@citrix.com> <560F229D.6030500@oracle.com>
CC: <xen-devel@lists.xen.org>, <david.vrabel@citrix.com>,
        <linux-kernel@vger.kernel.org>, <konrad.wilk@oracle.com>,
        <felipe.franciosi@citrix.com>, <axboe@fb.com>, <hch@infradead.org>,
        <avanzini.arianna@gmail.com>, <rafal.mielniczuk@citrix.com>,
        <boris.ostrovsky@oracle.com>, <jonathan.davies@citrix.com>
From: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Message-ID: <5612947F.4020107@citrix.com>
Date: Mon, 5 Oct 2015 17:17:19 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <560F229D.6030500@oracle.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

El 03/10/15 a les 2.34, Bob Liu ha escrit:
> 
> On 10/03/2015 01:02 AM, Roger Pau Monné wrote:
>> El 05/09/15 a les 14.39, Bob Liu ha escrit:
>> In order to make this easier to review, do you think you can leave
>> blkfront_info as "info" for now, and do the renaming to dinfo in a later
>> patch. That would help figuring out mechanical name changes from the
>> actual meat of the patch.
>>
> 
> That's what I have done in v2, but believe me it's more difficult to read and review.
> They are a lot of messed place combined with info and rinfo, when seeing an info you have to think 
> whether is device info or ring info. It's more straightforward to use dinfo and rinfo to distinguish at the beginning.

Ack, I was thinking of ways to limit the diff of this series, because
it's very big and hard to review in general. If you think the current
split is the best one I'm fine with that, thanks for trying to keep it
to a minimum.

Roger.