From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbbJEQk3 (ORCPT ); Mon, 5 Oct 2015 12:40:29 -0400 Received: from smtp-out-243.synserver.de ([212.40.185.243]:1054 "EHLO smtp-out-240.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751967AbbJEQk2 (ORCPT ); Mon, 5 Oct 2015 12:40:28 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 19057 Message-ID: <5612A7F7.3020607@metafoo.de> Date: Mon, 05 Oct 2015 18:40:23 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Cyrille Pitchen , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com CC: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH linux-next v3 1/1] ASoC: ad193x: add support to ad1934 References: <5fa6cd7e991982cea9f52d5ebba7a3aca7350ed7.1443537293.git.cyrille.pitchen@atmel.com> In-Reply-To: <5fa6cd7e991982cea9f52d5ebba7a3aca7350ed7.1443537293.git.cyrille.pitchen@atmel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks basically good. On 09/29/2015 04:41 PM, Cyrille Pitchen wrote: > The AD1934 codec has no DAC feature. Hence it register mapping is slightly Should be "has no ADC feature". Otherwise Acked-by: Lars-Peter Clausen