From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751684AbbJEV10 (ORCPT ); Mon, 5 Oct 2015 17:27:26 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:38321 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbbJEV1X (ORCPT ); Mon, 5 Oct 2015 17:27:23 -0400 Message-ID: <5612EB38.2050209@nexus-software.ie> Date: Mon, 05 Oct 2015 22:27:20 +0100 From: "Bryan O'Donoghue" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Kweh, Hock Leong" , Borislav Petkov CC: Matt Fleming , Greg Kroah-Hartman , "Ong, Boon Leong" , LKML , "linux-efi@vger.kernel.org" , Sam Protsenko , Peter Jones , Andy Lutomirski , Roy Franz , James Bottomley , Linux FS Devel , "Fleming, Matt" Subject: Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol References: <1444076155-19295-1-git-send-email-hock.leong.kweh@intel.com> <1444076155-19295-2-git-send-email-hock.leong.kweh@intel.com> <20151005131350.GA26329@nazgul.tnic> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/15 16:19, Kweh, Hock Leong wrote: >> -----Original Message----- >> From: Borislav Petkov [mailto:bp@alien8.de] >> Sent: Monday, October 05, 2015 9:14 PM >> >> So this one is still a separate patch. >> >> If you're going to ignore review comments, maybe I should stop wasting my >> time reviewing your stuff... >> >> -- >> Regards/Gruss, >> Boris. > > Already follow what you have suggested, put a note under --- line: > https://lkml.org/lkml/2015/10/5/230 (at line 25 - 27) > > Thanks for the review comments. Wilson - trying to test this out on a Galileo Gen2 - which branch are you doing this against ? I can apply the first patch you're proposing to squash your commit into https://lkml.org/lkml/diff/2014/10/7/390/1 but then trying to apply the first in your series on top of that patch I get deckard@aineko:~/Development/linux$ git apply ../patches/capsule_wilson/1_2.eml ../patches/capsule_wilson/1_2.eml:72: trailing whitespace. EXPORT_SYMBOL_GPL(efi_capsule_supported); error: drivers/firmware/efi/capsule.c: No such file or directory https://kernel.googlesource.com/pub/scm/linux/kernel/git/mfleming/efi/+/capsule/drivers/firmware/efi/capsule.c ?? If so - then why not use the interface here ? https://kernel.googlesource.com/pub/scm/linux/kernel/git/mfleming/efi/+/capsule (Sorry I know I'm coming to this thread late) Aside from that, I'm curious which types of capsules you've used here too - does it include the MFH header ? Keep in mind the initial firmware that shipped with Galileo will depend on that MFH being present. http://download.intel.com/support/processors/quark/sb/quark_securebootprm_330234_001.pdf - Section A1 - table 7 ? So if we boot a 4.x kernel with that initial firmware version 0.75 if memory serves - it's important that the capsule.c code handles the MFH. -- BOD