From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752713AbbJFLKb (ORCPT ); Tue, 6 Oct 2015 07:10:31 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:39938 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbbJFLK3 (ORCPT ); Tue, 6 Oct 2015 07:10:29 -0400 Subject: Re: [PATCH v3 00/27] memory: omap-gpmc: mtd: nand: Support GPMC NAND on non-OMAP platforms To: Tony Lindgren References: <1442588029-13769-1-git-send-email-rogerq@ti.com> <560BC0DB.5020205@ti.com> <20151006083346.GL23801@atomide.com> <56139A72.6040600@ti.com> <20151006100000.GN23801@atomide.com> <56139CE9.8020002@ti.com> <5613A256.8000105@ti.com> <20151006110134.GO23801@atomide.com> CC: , , , , , , , , , From: Roger Quadros Message-ID: <5613ABEF.9000904@ti.com> Date: Tue, 6 Oct 2015 14:09:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151006110134.GO23801@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/15 14:01, Tony Lindgren wrote: > * Roger Quadros [151006 03:32]: >> On 06/10/15 13:05, Roger Quadros wrote: >>> On 06/10/15 13:00, Tony Lindgren wrote: >>>> * Roger Quadros [151006 02:59]: >>>>> On 06/10/15 11:33, Tony Lindgren wrote: >>>>>> Does build and boot and use NAND work throughtout the series? >>>>>> Otherwise we'll have hard time bisecting anything.. >>>>> >>>>> Yes it does with the following exceptions. >>>>> >>>>> - Patch 7 "memory: omap-gpmc: Remove NAND IRQ code" breaks prefetch-irq mode >>>>> but none of the boards seem to be using it so it shouldn't break NAND on existing boards. >>>>> At patch 9 "mtd: nand: omap2: manage NAND interrupts" prefetch-irq mode is working again. >>>>> Do you want me to squash patches 7,8,9 so that pre-fetch irq is not broken at any point? >>>> >>>> OK, no that's fine, no need to squash them together then. >>>> >>>>> - Then at patch 11 "mtd: nand: omap: Clean up device tree support" we break NAND on all DT >>>>> boards as we expect NAND to be a real child node with compatible id. Simply applying the >>>>> DT patch at this point makes it work again. >>>> >>>> Hmm can we at least warn about incompatible DT entry when somebody boots >>>> with an older dtb? >>> >>> Yes that could be done. It looks like we can use the missing compatible property to identify >>> that it is and old DT entry. >>> >>> I'll send a v4 of patch 11. >> >> There is another issue. Some of the old DT nodes set the NAND IO address to 0. >> As we prevent mapping into first 16MB we see the following message for those nodes. e.g. dra7-evm >> >> [ 1.727598] omap-gpmc 50000000.gpmc: cannot remap GPMC CS 0 to 0x00000000 >> [ 1.727605] omap-gpmc 50000000.gpmc: GPMC CS 0 start cannot be lesser than 0x1000000 >> [ 1.727611] omap-gpmc 50000000.gpmc: failed to probe DT children >> >> Hope this is good enough information that DT needs to be updated? > > Yes I think that should allow users update the out of tree dts file > easily. Fine. The updated series is now at git@github.com:rogerq/linux.git * [new branch] for-v4.4/gpmc-v4 cheers, -roger