From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7A8C4338F for ; Sun, 22 Aug 2021 18:03:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE657611C2 for ; Sun, 22 Aug 2021 18:03:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231895AbhHVSED (ORCPT ); Sun, 22 Aug 2021 14:04:03 -0400 Received: from sibelius.xs4all.nl ([83.163.83.176]:53092 "EHLO sibelius.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230245AbhHVSEC (ORCPT ); Sun, 22 Aug 2021 14:04:02 -0400 Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 217fc3f5; Sun, 22 Aug 2021 20:03:18 +0200 (CEST) Date: Sun, 22 Aug 2021 20:03:18 +0200 (CEST) From: Mark Kettenis To: Alyssa Rosenzweig Cc: maz@kernel.org, linux-pci@vger.kernel.org, bhelgaas@google.com, robh+dt@kernel.org, lorenzo.pieralisi@arm.com, kw@linux.com, stan@corellium.com, kettenis@openbsd.org, sven@svenpeter.dev, marcan@marcan.st, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: (message from Alyssa Rosenzweig on Sun, 15 Aug 2021 21:34:36 -0400) Subject: Re: [RFC PATCH 1/2] dt-bindings: PCI: Add Apple PCI controller References: <20210815042525.36878-1-alyssa@rosenzweig.io> <20210815042525.36878-2-alyssa@rosenzweig.io> <87bl5z18vt.wl-maz@kernel.org> Message-ID: <56140c6524624af0@bloch.sibelius.xs4all.nl> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Date: Sun, 15 Aug 2021 21:34:36 -0400 > From: Alyssa Rosenzweig > > Hi Marc, > > > > Document the properties used by the Apple PCI controller. This is a > > > fairly standard PCI controller, although it is not derived from any > > > known non-Apple IP. > > > > > > Signed-off-by: Alyssa Rosenzweig > > > > I would rather you post something as an extension to Mark's work, for > > multiple reasons: > > > > - Mark's patch is still being discussed, and is the current > > reference (specially given that it is already in use in OpenBSD and > > u-boot). > > > > - we cannot have multiple bindings. There can only be one, shared > > across implementations. Otherwise, you need a different kernel > > depending on whether you are booting from m1n1 or u-boot. > > > > - what you have here is vastly inconsistent (you are describing the > > MSIs twice, using two different methods). > > Absolutely agree, the frankenstein bindings here were the main reason v1 > was marked RFC. For v2, I've rebased on Mark's patch, which makes a > bunch of driver magic disappear. I updated the t8103.dtsi bindings on the apple-m1-m1n1-nvme branch in my u-boot repository to be more in line with the current DT binding proposal. Note that the format of the msi-ranges property is still under discussion. See: http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210726083204.93196-2-mark.kettenis@xs4all.nl/ Cheers, Mark