From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756155AbbJHKqS (ORCPT ); Thu, 8 Oct 2015 06:46:18 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:34636 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751990AbbJHKqO convert rfc822-to-8bit (ORCPT ); Thu, 8 Oct 2015 06:46:14 -0400 Subject: Re: [PATCH v2 11/22] arm64: Populate cpuinfo after notify_cpu_starting To: Catalin Marinas References: <1444064531-25607-1-git-send-email-suzuki.poulose@arm.com> <1444064531-25607-12-git-send-email-suzuki.poulose@arm.com> <20151008101508.GE17192@e104818-lin.cambridge.arm.com> Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, Vladimir.Murzin@arm.com, steve.capper@linaro.org, ard.biesheuvel@linaro.org, marc.zyngier@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, edward.nevill@linaro.org, aph@redhat.com, james.morse@arm.com, andre.przywara@arm.com, dave.martin@arm.com From: "Suzuki K. Poulose" Message-ID: <56164972.3030906@arm.com> Date: Thu, 8 Oct 2015 11:46:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151008101508.GE17192@e104818-lin.cambridge.arm.com> X-OriginalArrivalTime: 08 Oct 2015 10:46:11.0147 (UTC) FILETIME=[8BCB09B0:01D101B6] X-MC-Unique: 4cfjD3xMSMmcD-A5vRj_rQ-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/15 11:15, Catalin Marinas wrote: > On Mon, Oct 05, 2015 at 06:02:00PM +0100, Suzuki K. Poulose wrote: >> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c >> index cb3e0d8..6987de4 100644 >> --- a/arch/arm64/kernel/smp.c >> +++ b/arch/arm64/kernel/smp.c >> @@ -163,14 +163,14 @@ asmlinkage void secondary_start_kernel(void) >> cpu_ops[cpu]->cpu_postboot(); >> >> /* >> - * Log the CPU info before it is marked online and might get read. >> + * Enable GIC and timers. >> */ >> - cpuinfo_store_cpu(); >> + notify_cpu_starting(cpu); >> >> /* >> - * Enable GIC and timers. >> + * Log the CPU info before it is marked online and might get read. >> */ >> - notify_cpu_starting(cpu); >> + cpuinfo_store_cpu(); >> >> smp_store_cpu_info(cpu); > > You can move the cpuinfo_store_cpu() call directly to > smp_store_cpu_info(). > That looks better, Thanks. Suzuki