From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932493AbbJMLzR (ORCPT ); Tue, 13 Oct 2015 07:55:17 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:56491 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752612AbbJMLzN (ORCPT ); Tue, 13 Oct 2015 07:55:13 -0400 X-AuditID: cbfee68e-f791c6d000001498-05-561cf11f6535 Message-id: <561CEEE3.7060401@samsung.com> Date: Tue, 13 Oct 2015 17:15:39 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Arnd Bergmann Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, JBottomley@odin.com, vinholikatti@gmail.com, amit.daniel@samsung.com, essuuj@gmail.com, devicetree@vger.kernel.org Subject: Re: [PATCH v3 12/13] scsi: ufs-exynos: add UFS host support for Exynos SoCs References: <1443686970-28104-1-git-send-email-alim.akhtar@samsung.com> <2228323.jdbqnSKW75@wuerfel> <561CE8CB.9010102@samsung.com> <6499659.hVBcEphJIR@wuerfel> In-reply-to: <6499659.hVBcEphJIR@wuerfel> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsWyRsSkVlf+o0yYweQ2TYuGqyEWfycdY7eY f+Qcq8XyC0uYLP6vv81icXnXHDaL7us72Cx2LKxy4PD4/WsSo8fOWXfZPQ7/+MHs0bdlFaPH 501yAaxRXDYpqTmZZalF+nYJXBkXZyxkKXjAVbHnyAKmBsYTHF2MnBwSAiYSdz/NZ4KwxSQu 3FvP1sXIxSEksIJR4tDaySwwRbs+f2OHSMxilLjTfI4ZwnnAKPH8wAt2kCpeAS2Jtw0TgGwO DhYBVYk1/2JBwmwC2hJ3p29hAgmLCkRIPL4gBFEtKPFj8j2w+SICihJTXzwDG8kssIVR4t2N qywg9cICYRKrDstDrFrCKNH+8T9YA6eApsSEo9uYQWxmAWuJlZO2MULY8hKb17wFGyQhcI1d 4sefF2ANLAICEt8mHwIbKiEgK7HpADPEY5ISB1fcYJnAKDYLyU2zkIydhWTsAkbmVYyiqQXJ BcVJ6UVGesWJucWleel6yfm5mxiB0Xf637O+HYw3D1gfYhTgYFTi4X0RKRMmxJpYVlyZe4jR FOiKicxSosn5wBjPK4k3NDYzsjA1MTU2Mrc0UxLnTZD6GSwkkJ5YkpqdmlqQWhRfVJqTWnyI kYmDU6qBUWz+Z/G3md32fRdvXgjY/tLuy5o3QbLH74XMvF7ibKtQupwnxcQuulpm4y2r9fXs ds6XjaaozM8IjpnGZFOqea3Lqjf7ePFxmcfmwSda/3ppTXhx3JJlabr+zvc9BQWTJVbnPl0x lSs8v25mBnds6GXRI80fzGr+TwsROVi2gfPaufKXWdmqSizFGYmGWsxFxYkATViIxbkCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsVy+t9jQV35jzJhBpuWKFk0XA2x+DvpGLvF /CPnWC2WX1jCZPF//W0Wi8u75rBZdF/fwWaxY2GVA4fH71+TGD12zrrL7nH4xw9mj74tqxg9 Pm+SC2CNamC0yUhNTEktUkjNS85PycxLt1XyDo53jjc1MzDUNbS0MFdSyEvMTbVVcvEJ0HXL zAE6RUmhLDGnFCgUkFhcrKRvh2lCaIibrgVMY4Sub0gQXI+RARpIWMOYcXHGQpaCB1wVe44s YGpgPMHRxcjJISFgIrHr8zd2CFtM4sK99WxdjFwcQgKzGCXuNJ9jhnAeMEo8P/ACrIpXQEvi bcMEIJuDg0VAVWLNv1iQMJuAtsTd6VuYQMKiAhESjy8IQVQLSvyYfI8FxBYRUJSY+uIZ2Ehm gS2MEu9uXGUBqRcWCJNYdVgeYtUSRon2j//BGjgFNCUmHN3GDGIzC1hLrJy0jRHClpfYvOYt 8wRGoCsRdsxCUjYLSdkCRuZVjBKpBckFxUnpuUZ5qeV6xYm5xaV56XrJ+bmbGMER/kx6B+Ph Xe6HGAU4GJV4eF9EyoQJsSaWFVfmHmKU4GBWEuFNagEK8aYkVlalFuXHF5XmpBYfYjQFhsFE ZinR5Hxg8skriTc0NjE3NTa1NLEwMbNUEue9cYghTEggPbEkNTs1tSC1CKaPiYNTqoEx7qea 7ba6Yy/D+VL6IxfE/Uu4WZ6kxi5vE2v8K5EjdIZxWbN3zT21Xf/63yxxqnIOb/xwztX34Dye paWXZuye8NE+r+uj87KLItkqsbqTdCuk9rmpfsl8dtjl2r2kniXLXLdnfpb5nVWiIvMkcttO wx/Ln2w9xXy8K/jeJnv9Cbucf52f/rBAiaU4I9FQi7moOBEASGcpzQYDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2015 05:08 PM, Arnd Bergmann wrote: > On Tuesday 13 October 2015 16:49:39 Alim Akhtar wrote: >>>> diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h >>>> new file mode 100644 >>>> index 0000000..58aa714 >>>> --- /dev/null >>>> +++ b/drivers/scsi/ufs/ufs-exynos.h >>>> @@ -0,0 +1,463 @@ >>>> +/* >>>> + * UFS Host Controller driver for Exynos specific extensions >>>> + * >>>> + * Copyright (C) 2014-2015 Samsung Electronics Co., Ltd. >>>> + * >>>> + * This program is free software; you can redistribute it and/or modify >>>> + * it under the terms of the GNU General Public License as published by >>>> + * the Free Software Foundation; either version 2 of the License, or >>>> + * (at your option) any later version. >>>> + */ >>>> + >>>> +#ifndef _UFS_EXYNOS_H_ >>>> +#define _UFS_EXYNOS_H_ >>> >>> You have a lot of things in this header that are only used in one of the >>> .c files, so just move them there and make the header as small as possible. >>> >> hmm..these are mostly the registers defines, will removes the one which >> are not being used as of now. >> Do you think I should sill move them to .c file? >> > > Yes. No need to remove the unused register definitions, just don't put > them into a separate header if they are only used in one place. > Ok will do that in v4. Thanks. > Arnd >