From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932530AbbJNOsJ (ORCPT ); Wed, 14 Oct 2015 10:48:09 -0400 Received: from rcdn-iport-4.cisco.com ([173.37.86.75]:16974 "EHLO rcdn-iport-4.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753492AbbJNOsF (ORCPT ); Wed, 14 Oct 2015 10:48:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BfAgAzah5W/5pdJa1egya6Q4QhAQ2BWoMTggp/AoFBOBQBAQEBAQEBgQqEJwEBBCMVPAQBEAsaAgUWCwICCQMCAQIBRQYNCAEBiCqvTZNAAQEBAQEBAQEBAQEBAQEBAQEBGguBF4VUhH6FDQeCaYFFAQSOA4gSjRuBWIc7jwiDbx8BAUKEIh6HIgEBAQ X-IronPort-AV: E=Sophos;i="5.17,681,1437436800"; d="scan'208";a="37485366" Subject: Re: [PATCH-RFC 6/7] drivers: of: ifdef out cmdline section To: Rob Herring References: <1444146434-12776-6-git-send-email-danielwa@cisco.com> <20151007162755.GA23283@fifo99.com> <561D6603.4060006@cisco.com> Cc: Daniel Walker , xe-kernel@external.cisco.com, Frank Rowand , Grant Likely , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Daniel Walker Message-ID: <561E6B22.1030204@cisco.com> Date: Wed, 14 Oct 2015 07:48:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Auto-Response-Suppress: DR, OOF, AutoReply Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's one last little wrinkle .. In the current setup the defconfig CONFIG_CMDLINE="" is used as a default in case the device tree has nothing in it. In my changes, there is no identical functionality. The only similar thing I have is the the CONFIG_CMDLINE_APPEND="" . The main difference is that in the current implementation CONFIG_CMDLINE="" doesn't get added at all if there is a device tree bootargs, but with my implementation this line would be added unconditionally. It would represent a subtle change where people would have to add into the DT bootargs something to override what might be in the default command line. For example, if a config has CONFIG_CMDLINE_APPEND="debug" then they would have to add a "loglevel=7" into the DT bootargs to get back to normal. I wouldn't think people would want "debug" as the default, but oddly enough some of the configs do have this. Some of them also have default ip address setting, nfsroot= settings, and loglevel= settings. What are your thoughts on this ? I think using the append type default makes more sense because it's actually setting up global defaults. The current complete replacement scheme seems to set the stage for people to make an entirely custom default for a single development machine, which IMO doesn't make sense. However, I'm not sure what the intent is with the current setup. Daniel