From: Randy Dunlap <rdunlap@infradead.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Adrian Bunk <bunk@kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Adrian Bunk <bunk@debian.org>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mtd@lists.infradead.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: onenand: fix parameter list build warning
Date: Tue, 4 Sep 2018 14:49:00 -0700 [thread overview]
Message-ID: <561f2078-92e8-290f-626c-ff936b7285c1@infradead.org> (raw)
In-Reply-To: <20180904233449.32e41787@xps13>
On 09/04/2018 02:34 PM, Miquel Raynal wrote:
> Hi Randy,
>
> Randy Dunlap <rdunlap@infradead.org> wrote on Mon, 3 Sep 2018 12:32:04
> -0700:
>
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix build warning in <linux/mtd/onenand.h> by adding a "stub" struct
>> for mtd_oob_ops:
>>
>> include/linux/mtd/onenand.h: warning: 'struct mtd_oob_ops' declared inside parameter list [enabled by default]
>> include/linux/mtd/onenand.h: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>>
>> Fixes: 607d1cb10426 ("[MTD] [OneNAND] proper onenand_bbt_read_oob() prototype")
>>
>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Kyungmin Park <kyungmin.park@samsung.com>
>> Cc: linux-mtd@lists.infradead.org
>> Cc: David Woodhouse <dwmw2@infradead.org>
>> Cc: Brian Norris <computersforpeace@gmail.com>
>> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
>> Cc: Marek Vasut <marek.vasut@gmail.com>
>> Cc: Richard Weinberger <richard@nod.at>
>> Cc: Adrian Bunk <bunk@kernel.org>
>> Cc: Adrian Bunk <bunk@debian.org>
>> ---
>> include/linux/mtd/onenand.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- lnx-419-rc2.orig/include/linux/mtd/onenand.h
>> +++ lnx-419-rc2/include/linux/mtd/onenand.h
>> @@ -221,6 +221,7 @@ struct onenand_manufacturers {
>> char *name;
>> };
>>
>> +struct mtd_oob_ops;
>> int onenand_bbt_read_oob(struct mtd_info *mtd, loff_t from,
>> struct mtd_oob_ops *ops);
>> unsigned onenand_block(struct onenand_chip *this, loff_t addr);
>
> That's indeed a working solution, but there are a lot of other
> structures in this file that come (like mtd_oob_ops) from
> linux/mtd/mtd.h so I wonder if it would not make more sense to include
> this header here?
>
> Thanks,
> Miquèl
Hi,
Have you see this from Linus?
https://lore.kernel.org/lkml/CA+55aFzMBptQt-QHMR0MM9MA3=1rxcf8ca5qHxrf4Mm0ZobE_A@mail.gmail.com/
thanks,
--
~Randy
next prev parent reply other threads:[~2018-09-04 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 19:32 [PATCH] mtd: onenand: fix parameter list build warning Randy Dunlap
2018-09-04 21:34 ` Miquel Raynal
2018-09-04 21:49 ` Randy Dunlap [this message]
2018-09-05 8:00 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561f2078-92e8-290f-626c-ff936b7285c1@infradead.org \
--to=rdunlap@infradead.org \
--cc=boris.brezillon@bootlin.com \
--cc=bunk@debian.org \
--cc=bunk@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=geert@linux-m68k.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).