From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 569DEC00140 for ; Fri, 5 Aug 2022 09:16:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240410AbiHEJQH (ORCPT ); Fri, 5 Aug 2022 05:16:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240357AbiHEJQG (ORCPT ); Fri, 5 Aug 2022 05:16:06 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3567F12089 for ; Fri, 5 Aug 2022 02:16:03 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id m22so2561104lfl.9 for ; Fri, 05 Aug 2022 02:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=dyFEWJikncIBUJyKkX0jolBEiIcSUSNj0WDThZ5+3Bg=; b=JcLF69Mv0lfG2mXQv9/1bOz44C/ZSw2PCUbahxeYH5l3+7CmI6YZnCHLxX6jhOBlTA BHf32eHA4uCAslWOeFV0FbEFBTjtXS5k4BXfbP1JC2NTQ/aoOU8zVjh2UaVLuVMFvUZV HixQrwLnQt21NM6GdrqggGp91cpM5XbX5qd2iNSmSDSVKX0/jh+w8/Lq8iVncfSdUjmT jCc/JmEdECHY+vJenOW3sue5jGgwk2AUtJrAanl+nM2ZeSIbdHvarj0W/hTurLyOyEQU x9Gsa2Q6Pv/HdUUHGWMwFu/SVDMZFnCaZJSLB8rdN51b/65p9x9t6AiBjhBIj+wg5WR6 vQaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=dyFEWJikncIBUJyKkX0jolBEiIcSUSNj0WDThZ5+3Bg=; b=rwQSp7NrM/PeVdzZnGTrIrf2b8TGbkAqPv9F+TULyZLFZxiJiC18Bpuw3DxJw1QR2L JKw7/X5FrbTTb/N05jFl9YM8Hsk5vKegnCHvRDt7bWjkoHaZHKXv8kdJGfyBTCvW6/tJ 0j4Rl2sGcxKBJUYw0U+2UJKMOGzNKWojEJ0SGXGxvsNu7nZlMRO73gbPOROrkrrzPTbB 3VzTbBHNW2QCGHe/jqBPY+dj9Sq1aXY1/F/wudRcp982Fx1nuugDN07ofS+llDjkNDS5 1DCr7ZlR4CHJjXTDePrkZOW8bn2SUoIl/zfhvbZizO7a1IGDi2x0FnNHJMxbwj9TYWLU 2Xbg== X-Gm-Message-State: ACgBeo3pPKvwRBF2oZDsxL/DM7jIbiYIdxyK9t/OriZB4q+u1pqMl5kP KAcuGuQsPf5ejWDiBJoPMDQreQ== X-Google-Smtp-Source: AA6agR45ewObgP7I+JAAZ3xFIRQLIe9iM1Wkc+5mixLQG57foQ03YMiFezSy/cXa4p0N2TrOZfffuw== X-Received: by 2002:a05:6512:e8c:b0:48a:f47a:63e3 with SMTP id bi12-20020a0565120e8c00b0048af47a63e3mr2200808lfb.325.1659690961562; Fri, 05 Aug 2022 02:16:01 -0700 (PDT) Received: from [192.168.1.6] ([77.222.167.48]) by smtp.gmail.com with ESMTPSA id bi24-20020a05651c231800b0025ebaef9570sm15933ljb.40.2022.08.05.02.15.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 02:15:49 -0700 (PDT) Message-ID: <562043e1-83d4-d4ab-2c18-20b770b02955@linaro.org> Date: Fri, 5 Aug 2022 11:15:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH V3 4/6] dt-bindings: clk: meson: add S4 SoC peripheral clock controller bindings Content-Language: en-US To: Yu Tu , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Neil Armstrong , Jerome Brunet , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Martin Blumenstingl References: <20220805085716.5635-1-yu.tu@amlogic.com> <20220805085716.5635-5-yu.tu@amlogic.com> From: Krzysztof Kozlowski In-Reply-To: <20220805085716.5635-5-yu.tu@amlogic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/2022 10:57, Yu Tu wrote: > Add peripheral clock controller compatible and dt-bindings header for > the of the S4 SoC. > > Signed-off-by: Yu Tu > --- > .../bindings/clock/amlogic,s4-clkc.yaml | 92 ++++++++++++ > include/dt-bindings/clock/amlogic,s4-clkc.h | 131 ++++++++++++++++++ > 2 files changed, 223 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,s4-clkc.yaml > create mode 100644 include/dt-bindings/clock/amlogic,s4-clkc.h > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,s4-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,s4-clkc.yaml > new file mode 100644 > index 000000000000..2471276afda9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/amlogic,s4-clkc.yaml Filename should be based on compatible, so amlogic,s4-periphs-clkc.yaml > @@ -0,0 +1,92 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/amlogic,s4-clkc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic Meson S serials Peripheral Clock Controller Device Tree Bindings s/Device Tree Bindings// > + > +maintainers: > + - Neil Armstrong > + - Jerome Brunet > + - Yu Tu > + > + > +properties: > + compatible: > + const: amlogic,s4-periphs-clkc > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: input fixed pll div2 > + - description: input fixed pll div2p5 > + - description: input fixed pll div3 > + - description: input fixed pll div4 > + - description: input fixed pll div5 > + - description: input fixed pll div7 > + - description: input hifi pll > + - description: input gp0 pll > + - description: input mpll0 > + - description: input mpll1 > + - description: input mpll2 > + - description: input mpll3 > + - description: input hdmi pll > + - description: input oscillator (usually at 24MHz) > + > + clock-names: > + items: > + - const: fclk_div2 > + - const: fclk_div2p5 > + - const: fclk_div3 > + - const: fclk_div4 > + - const: fclk_div5 > + - const: fclk_div7 > + - const: hifi_pll > + - const: gp0_pll > + - const: mpll0 > + - const: mpll1 > + - const: mpll2 > + - const: mpll3 > + - const: hdmi_pll > + - const: xtal > + > + "#clock-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - "#clock-cells" > + > +additionalProperties: false > + > +examples: > + - | > + clkc_periphs: periphs-clock-controller@fe000000 { > + compatible = "amlogic,s4-periphs-clkc"; > + reg = <0xfe000000 0x49c>; > + clocks = <&clkc_pll 3>, > + <&clkc_pll 13>, > + <&clkc_pll 5>, > + <&clkc_pll 7>, > + <&clkc_pll 9>, > + <&clkc_pll 11>, > + <&clkc_pll 17>, > + <&clkc_pll 15>, > + <&clkc_pll 25>, > + <&clkc_pll 27>, > + <&clkc_pll 29>, > + <&clkc_pll 31>, > + <&clkc_pll 20>, > + <&xtal>; > + clock-names = "fclk_div2", "fclk_div2p5", "fclk_div3", "fclk_div4", > + "fclk_div5", "fclk_div7", "hifi_pll", "gp0_pll", > + "mpll0", "mpll1", "mpll2", "mpll3", "hdmi_pll", "xtal"; > + #clock-cells = <1>; > + }; > +... > diff --git a/include/dt-bindings/clock/amlogic,s4-clkc.h b/include/dt-bindings/clock/amlogic,s4-clkc.h > new file mode 100644 > index 000000000000..d203b9bbf29e > --- /dev/null > +++ b/include/dt-bindings/clock/amlogic,s4-clkc.h Probably this should be then amlogic,s4-periphs-clkc.h > @@ -0,0 +1,131 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > +/* > + * Copyright (c) 2021 Amlogic, Inc. All rights reserved. > + * Author: Yu Tu > + */ > + > +#ifndef _DT_BINDINGS_CLOCK_AMLOGIC_S4_CLKC_H > +#define _DT_BINDINGS_CLOCK_AMLOGIC_S4_CLKC_H Best regards, Krzysztof