From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754028AbbJPIxm (ORCPT ); Fri, 16 Oct 2015 04:53:42 -0400 Received: from smtp-out-206.synserver.de ([212.40.185.206]:1075 "EHLO smtp-out-188.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752382AbbJPIxk (ORCPT ); Fri, 16 Oct 2015 04:53:40 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 22613 Message-ID: <5620BB0E.9040400@metafoo.de> Date: Fri, 16 Oct 2015 10:53:34 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Jon Hunter , Laxman Dewangan , Vinod Koul , Stephen Warren , Thierry Reding , Alexandre Courbot CC: dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal References: <1444983957-18691-1-git-send-email-jonathanh@nvidia.com> <1444983957-18691-7-git-send-email-jonathanh@nvidia.com> In-Reply-To: <1444983957-18691-7-git-send-email-jonathanh@nvidia.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2015 10:25 AM, Jon Hunter wrote: > On driver removal, before killing any tasklets, ensure that the channel > interrupts are disabled so that the tasklet will not try to run during > or after the removal of the driver. > > Signed-off-by: Jon Hunter > --- > drivers/dma/tegra20-apb-dma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c > index 2bfab8d28b53..0dd6e7deaa8e 100644 > --- a/drivers/dma/tegra20-apb-dma.c > +++ b/drivers/dma/tegra20-apb-dma.c > @@ -1492,6 +1492,7 @@ static int tegra_dma_remove(struct platform_device *pdev) > > for (i = 0; i < tdma->chip_data->nr_channels; ++i) { > tdc = &tdma->channels[i]; > + disable_irq(tdc->irq); How about just calling free_irq()? That's how you'd typically handle this. > tasklet_kill(&tdc->tasklet); > } > >