From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753991AbbJPJ3s (ORCPT ); Fri, 16 Oct 2015 05:29:48 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:7471 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752222AbbJPJ3p (ORCPT ); Fri, 16 Oct 2015 05:29:45 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Fri, 16 Oct 2015 02:21:22 -0700 Subject: Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal To: Lars-Peter Clausen , Laxman Dewangan , Vinod Koul , Stephen Warren , Thierry Reding , "Alexandre Courbot" References: <1444983957-18691-1-git-send-email-jonathanh@nvidia.com> <1444983957-18691-7-git-send-email-jonathanh@nvidia.com> <5620BB0E.9040400@metafoo.de> CC: , , From: Jon Hunter Message-ID: <5620C383.3060104@nvidia.com> Date: Fri, 16 Oct 2015 10:29:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5620BB0E.9040400@metafoo.de> X-Originating-IP: [10.21.132.152] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/10/15 09:53, Lars-Peter Clausen wrote: > On 10/16/2015 10:25 AM, Jon Hunter wrote: >> On driver removal, before killing any tasklets, ensure that the channel >> interrupts are disabled so that the tasklet will not try to run during >> or after the removal of the driver. >> >> Signed-off-by: Jon Hunter >> --- >> drivers/dma/tegra20-apb-dma.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c >> index 2bfab8d28b53..0dd6e7deaa8e 100644 >> --- a/drivers/dma/tegra20-apb-dma.c >> +++ b/drivers/dma/tegra20-apb-dma.c >> @@ -1492,6 +1492,7 @@ static int tegra_dma_remove(struct platform_device *pdev) >> >> for (i = 0; i < tdma->chip_data->nr_channels; ++i) { >> tdc = &tdma->channels[i]; >> + disable_irq(tdc->irq); > > How about just calling free_irq()? That's how you'd typically handle this. Yes, however, the interrupt is requested by devm_request_irq(). I guess I could call devm_free_irq() here? Cheers Jon