linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	<stefano.stabellini@eu.citrix.com>,
	<linux-kernel@vger.kernel.org>, <ian.campbell@citrix.com>,
	David Vrabel <david.vrabel@citrix.com>
Subject: Re: [Xen-devel] [PATCH 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages
Date: Mon, 19 Oct 2015 12:36:31 +0100	[thread overview]
Message-ID: <5624D5BF.7020605@citrix.com> (raw)
In-Reply-To: <5624D0F5.60207@citrix.com>

On 19/10/15 12:16, Roger Pau Monné wrote:
> At this point I don't think it's worth implementing it, if you feel like
> doing that later in order to improve performance that would be fine, but
> I don't think it should be required in order to get this merged.

I would rather avoid to improve performance in the frontend and
encourage people to implement indirect descriptor in their backend.

It would be more beneficial for any block frontend (x86, arm, 4K pages,
64K pages...).

> I think you had to resend the patch anyway to fix some comments, but
> apart from that:

Note that I'm planning to update the commit message to summarize my
previous mail.

> Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thank you, I will try to resend a new version today.

Regards,

-- 
Julien Grall

  reply	other threads:[~2015-10-19 11:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 19:31 [PATCH 0/2] block/xen-blkfront: Support non-indirect with 64KB page granularity Julien Grall
2015-09-11 19:31 ` [PATCH 1/2] block/xen-blkfront: Introduce blkif_ring_get_request Julien Grall
2015-10-05 15:22   ` Roger Pau Monné
2015-09-11 19:32 ` [PATCH 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages Julien Grall
2015-10-05 16:01   ` Roger Pau Monné
2015-10-05 17:05     ` [Xen-devel] " Julien Grall
2015-10-06  9:39       ` Roger Pau Monné
2015-10-06  9:58         ` Julien Grall
2015-10-06 10:06           ` Roger Pau Monné
2015-10-12 18:00             ` Julien Grall
2015-10-19 11:16               ` Roger Pau Monné
2015-10-19 11:36                 ` Julien Grall [this message]
2015-09-12  9:46 ` [Xen-devel] [PATCH 0/2] block/xen-blkfront: Support non-indirect with 64KB page granularity Bob Liu
2015-09-13 12:06   ` Julien Grall
2015-09-13 12:44     ` Bob Liu
2015-09-13 17:47       ` Julien Grall
2015-09-14  0:37         ` Bob Liu
2015-10-02  9:32 ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5624D5BF.7020605@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).