From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756418AbbJVB4z (ORCPT ); Wed, 21 Oct 2015 21:56:55 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:36455 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755693AbbJVB4x (ORCPT ); Wed, 21 Oct 2015 21:56:53 -0400 Subject: Re: [PATCH 1/3] dt-bindings: Add document of Rockchip mailbox To: Rob Herring References: <1442228798-15191-1-git-send-email-wxt@rock-chips.com> <1442228798-15191-2-git-send-email-wxt@rock-chips.com> Cc: Caesar Wang , Mark Rutland , "devicetree@vger.kernel.org" , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Pawel Moll , Ian Campbell , frank.wang@rock-chips.com, Catalin Marinas , Jaswinder Singh , Will Deacon , "linux-kernel@vger.kernel.org" , linux-rockchip@lists.infradead.org, Kumar Gala , Olof Johansson , "linux-arm-kernel@lists.infradead.org" From: Caesar Wang Message-ID: <56284256.1020205@gmail.com> Date: Thu, 22 Oct 2015 09:56:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'm missing this patch for long time. 在 2015年10月06日 22:50, Rob Herring 写道: > On Mon, Sep 14, 2015 at 6:06 AM, Caesar Wang wrote: >> This add the necessary binding documentation for mailbox >> found on RK3368 SoC. >> >> Signed-off-by: Caesar Wang >> --- >> >> .../bindings/mailbox/rockchip-mailbox.txt | 33 ++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt >> >> diff --git a/Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt b/Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt >> new file mode 100644 >> index 0000000..b9b4768 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mailbox/rockchip-mailbox.txt >> @@ -0,0 +1,33 @@ >> +Rockchip mailbox >> + >> +The Rockchip mailbox is used by the Rockchip CPU cores to communicate >> +requests to MCU processor. >> + >> +Refer to ./mailbox.txt for generic information about mailbox device-tree >> +bindings. >> + >> +Required properties: >> + >> + - compatible: should be one of the following. >> + - "rockchip,rk3368-mbox" for rk3368 >> + - reg: physical base address of the controller and length of memory mapped >> + region. >> + physical base address of the share buffer and length of memory mapped > s/share/shared/ Done. > >> + region. >> + - interrupts: The interrupt number to the cpu. The interrupt specifier format >> + depends on the interrupt controller. > Need to specify the value of #mbox-cells. Done. >> + >> +Example: >> +-------- >> + >> +/* RK3368 */ >> +mbox: mbox@ff6b0000 { >> + compatible = "rockchip,rk3368-mailbox"; >> + reg = <0x0 0xff6b0000 0x0 0x1000>, >> + <0x0 0xff8cf000 0x0 0x1000>; /* the end 4k of sram */ > If this is just onchip SRAM usable for anything, then use the SRAM > binding (misc/sram.txt). It has provisions for defining the use. Okay, we don't need define the shared-sram in this document. >> + interrupts = , >> + , >> + , >> + ; >> + #mbox-cells = <1>; >> +}; >> -- >> 1.9.1 >> > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Thanks, Caesar