From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751568AbbJYMgk (ORCPT ); Sun, 25 Oct 2015 08:36:40 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:59107 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbbJYMgj (ORCPT ); Sun, 25 Oct 2015 08:36:39 -0400 Subject: Re: [PATCH 1/2] iio: adc: mcp320x: Deprecated compatible strings with no vendor prefix To: Michael Welling , Javier Martinez Canillas References: <1444827279-23163-1-git-send-email-javier@osg.samsung.com> <1444827279-23163-2-git-send-email-javier@osg.samsung.com> <20151014152726.GA29846@deathstar> Cc: linux-kernel@vger.kernel.org, Andrea Galbusera , devicetree@vger.kernel.org, Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Mark Rutland , =?UTF-8?Q?S=c3=b8ren_Andersen?= From: Jonathan Cameron Message-ID: <562CCCD5.4030307@kernel.org> Date: Sun, 25 Oct 2015 12:36:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151014152726.GA29846@deathstar> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/10/15 16:27, Michael Welling wrote: > On Wed, Oct 14, 2015 at 02:54:38PM +0200, Javier Martinez Canillas wrote: >> The Microchip Analog to Digital Converter (ADC) Device Tree binding >> documents compatible strings with no vendor prefix. Since it should >> compatible strings with also a vendor, add these to the binding doc >> and mark the old ones as deprecated. >> >> The driver says that the device is from Microchip Technology which >> is listed in Documentation/devicetree/bindings/vendor-prefixes.txt >> so use the documented prefix. >> >> Signed-off-by: Javier Martinez Canillas >> --- >> >> .../devicetree/bindings/iio/adc/mcp320x.txt | 30 +++++++++++++++------- >> 1 file changed, 21 insertions(+), 9 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt >> index 2a1f3af30155..bcd3ac8e6e0c 100644 >> --- a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt >> +++ b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt >> @@ -10,16 +10,28 @@ must be specified. >> Required properties: >> - compatible: Must be one of the following, depending on the >> model: >> - "mcp3001" >> - "mcp3002" >> - "mcp3004" >> - "mcp3008" >> - "mcp3201" >> - "mcp3202" >> - "mcp3204" >> - "mcp3208" >> - "mcp3301" >> + "mcp3001" (DEPRECATED) >> + "mcp3002" (DEPRECATED) >> + "mcp3004" (DEPRECATED) >> + "mcp3008" (DEPRECATED) >> + "mcp3201" (DEPRECATED) >> + "mcp3202" (DEPRECATED) >> + "mcp3204" (DEPRECATED) >> + "mcp3208" (DEPRECATED) >> + "mcp3301" (DEPRECATED) >> >> + "microchip,mcp3001" >> + "microchip,mcp3002" >> + "microchip,mcp3004" >> + "microchip,mcp3008" >> + "microchip,mcp3201" >> + "microchip,mcp3202" >> + "microchip,mcp3204" >> + "microchip,mcp3208" >> + "microchip,mcp3301" >> + >> + NOTE: The use of the compatibles with no vendor prefix >> + is deprecated and only listed because old DT use them. >> > > Acked-by: Michael Welling Small point, Michael. Please add such acks below the the Author sign off. Otherwise sometimes I miss them! Added it now for this one. > >> Examples: >> spi_controller { >> -- >> 2.4.3 >>