From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752909AbbJZV4w (ORCPT ); Mon, 26 Oct 2015 17:56:52 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33301 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbbJZV4t (ORCPT ); Mon, 26 Oct 2015 17:56:49 -0400 Subject: Re: [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings To: Yaniv Gardi , robherring2@gmail.com, James.Bottomley@HansenPartnership.com, pebolle@tiscali.nl, hch@infradead.org References: <1445874072-25909-1-git-send-email-ygardi@codeaurora.org> <1445874072-25909-18-git-send-email-ygardi@codeaurora.org> Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org, gbroner@codeaurora.org, draviv@codeaurora.org, Vinayak Holikatti , "James E.J. Bottomley" From: Stephen Boyd Message-ID: <562EA19E.2070007@codeaurora.org> Date: Mon, 26 Oct 2015 14:56:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1445874072-25909-18-git-send-email-ygardi@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2015 08:41 AM, Yaniv Gardi wrote: > Tnis patch fixes the following compilation warnings: > ...ufs-qcom.c:1201:40: > warning: incorrect type in argument 1 (different address spaces) > ...ufs-qcom.c:1201:40: > expected void const *ptr > ...ufs-qcom.c:1201:40: > got void [noderef] *dev_ref_clk_ctrl_mmio > ...ufs-qcom.c:1207:53: > warning: incorrect type in argument 1 (different address spaces) > ...ufs-qcom.c:1207:53: > expected void const *ptr > ...ufs-qcom.c:1207:53: > got void [noderef] *dev_ref_clk_ctrl_mmio > > Signed-off-by: Yaniv Gardi > > --- What version of sparse do you use? You shouldn't need to do this. > drivers/scsi/ufs/ufs-qcom.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index 72b0ef7..b57f88a 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -1226,11 +1226,12 @@ static int ufs_qcom_init(struct ufs_hba *hba) > if (res) { > host->dev_ref_clk_ctrl_mmio = > devm_ioremap_resource(dev, res); > - if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) { > - dev_warn(dev, > - "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n", > + if (IS_ERR((__force void const *) > + host->dev_ref_clk_ctrl_mmio)) { > + dev_warn(dev, "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n", > __func__, > - PTR_ERR(host->dev_ref_clk_ctrl_mmio)); > + PTR_ERR((__force void const *) > + host->dev_ref_clk_ctrl_mmio)); > host->dev_ref_clk_ctrl_mmio = NULL; > } > host->dev_ref_clk_en_mask = BIT(5); -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project