linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: mediatek: mt8173 PSCI-1.0 support
@ 2015-08-28  2:11 fan.chen
  2015-09-27 14:23 ` Matthias Brugger
  2015-10-27 10:52 ` Matthias Brugger
  0 siblings, 2 replies; 3+ messages in thread
From: fan.chen @ 2015-08-28  2:11 UTC (permalink / raw)
  To: Mark Rutland, Matthias Brugger
  Cc: srv_heupstream, Rob Herring, Pawel Moll, Ian Campbell,
	Kumar Gala, Catalin Marinas, Will Deacon, Daniel Kurtz,
	Sascha Hauer, Eddie Huang, Daniel Lezcano, Howard Chen,
	Yingjoe Chen, devicetree, linux-arm-kernel, linux-kernel,
	linux-mediatek, Sudeep Holla, Fan Chen

From: Fan Chen <fan.chen@mediatek.com>

This patch adds psci comatible properties to support all mandatory
functions of PSCI-1.0, PSCI-0.2 and PSCI-0.1, and system suspend
can be supported in PSCI-1.0.

Signed-off-by: Fan Chen <fan.chen@mediatek.com>
---
Because PSCI-1.0 patches hadn't landed on mainline, this patch is
based on three patch sets below:
[0] http://www.spinics.net/lists/arm-kernel/msg425793.html
    PSCI: system suspend support
[1] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git
    psci/unification
[2] http://www.spinics.net/lists/devicetree/msg82017.html
    [PATCH 0/6] drivers: firmware: psci: add basic v1.0 support

Before they are merged in, this patch still works fine with psci-0.2
support in current mainline.
---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index d18ee42..b9b4205 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -95,7 +95,7 @@
 	};
 
 	psci {
-		compatible = "arm,psci";
+		compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
 		method = "smc";
 		cpu_suspend   = <0x84000001>;
 		cpu_off	      = <0x84000002>;
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt8173 PSCI-1.0 support
  2015-08-28  2:11 [PATCH] arm64: dts: mediatek: mt8173 PSCI-1.0 support fan.chen
@ 2015-09-27 14:23 ` Matthias Brugger
  2015-10-27 10:52 ` Matthias Brugger
  1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2015-09-27 14:23 UTC (permalink / raw)
  To: fan.chen, Mark Rutland
  Cc: srv_heupstream, Rob Herring, Pawel Moll, Ian Campbell,
	Kumar Gala, Catalin Marinas, Will Deacon, Daniel Kurtz,
	Sascha Hauer, Eddie Huang, Daniel Lezcano, Howard Chen,
	Yingjoe Chen, devicetree, linux-arm-kernel, linux-kernel,
	linux-mediatek, Sudeep Holla



On 28/08/15 04:11, fan.chen@mediatek.com wrote:
> From: Fan Chen <fan.chen@mediatek.com>
>
> This patch adds psci comatible properties to support all mandatory
> functions of PSCI-1.0, PSCI-0.2 and PSCI-0.1, and system suspend
> can be supported in PSCI-1.0.
>
> Signed-off-by: Fan Chen <fan.chen@mediatek.com>
> ---
> Because PSCI-1.0 patches hadn't landed on mainline, this patch is
> based on three patch sets below:
> [0] http://www.spinics.net/lists/arm-kernel/msg425793.html
>      PSCI: system suspend support
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git
>      psci/unification
> [2] http://www.spinics.net/lists/devicetree/msg82017.html
>      [PATCH 0/6] drivers: firmware: psci: add basic v1.0 support
>
> Before they are merged in, this patch still works fine with psci-0.2
> support in current mainline.
> ---
>   arch/arm64/boot/dts/mediatek/mt8173.dtsi |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index d18ee42..b9b4205 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -95,7 +95,7 @@
>   	};
>
>   	psci {
> -		compatible = "arm,psci";
> +		compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";

As this binding is not yet upstream, I prefer not to take the patch. 
Most probably the binding will have the name you indicated, but as DTS 
bindings are representing an external API, we should be really careful 
in changing them.

Cheers,
Matthias

>   		method = "smc";
>   		cpu_suspend   = <0x84000001>;
>   		cpu_off	      = <0x84000002>;
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt8173 PSCI-1.0 support
  2015-08-28  2:11 [PATCH] arm64: dts: mediatek: mt8173 PSCI-1.0 support fan.chen
  2015-09-27 14:23 ` Matthias Brugger
@ 2015-10-27 10:52 ` Matthias Brugger
  1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2015-10-27 10:52 UTC (permalink / raw)
  To: fan.chen, Mark Rutland
  Cc: srv_heupstream, Rob Herring, Pawel Moll, Ian Campbell,
	Kumar Gala, Catalin Marinas, Will Deacon, Daniel Kurtz,
	Sascha Hauer, Eddie Huang, Daniel Lezcano, Howard Chen,
	Yingjoe Chen, devicetree, linux-arm-kernel, linux-kernel,
	linux-mediatek, Sudeep Holla



On 28/08/15 04:11, fan.chen@mediatek.com wrote:
> From: Fan Chen <fan.chen@mediatek.com>
>
> This patch adds psci comatible properties to support all mandatory
> functions of PSCI-1.0, PSCI-0.2 and PSCI-0.1, and system suspend
> can be supported in PSCI-1.0.
>
> Signed-off-by: Fan Chen <fan.chen@mediatek.com>
> ---

Applied to v4.4-next/arm64

Thanks,
Matthias

> Because PSCI-1.0 patches hadn't landed on mainline, this patch is
> based on three patch sets below:
> [0] http://www.spinics.net/lists/arm-kernel/msg425793.html
>      PSCI: system suspend support
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git
>      psci/unification
> [2] http://www.spinics.net/lists/devicetree/msg82017.html
>      [PATCH 0/6] drivers: firmware: psci: add basic v1.0 support
>
> Before they are merged in, this patch still works fine with psci-0.2
> support in current mainline.
> ---
>   arch/arm64/boot/dts/mediatek/mt8173.dtsi |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index d18ee42..b9b4205 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -95,7 +95,7 @@
>   	};
>
>   	psci {
> -		compatible = "arm,psci";
> +		compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
>   		method = "smc";
>   		cpu_suspend   = <0x84000001>;
>   		cpu_off	      = <0x84000002>;
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-10-27 10:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-28  2:11 [PATCH] arm64: dts: mediatek: mt8173 PSCI-1.0 support fan.chen
2015-09-27 14:23 ` Matthias Brugger
2015-10-27 10:52 ` Matthias Brugger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).