From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932390AbbJ0OXe (ORCPT <rfc822;w@1wt.eu>);
	Tue, 27 Oct 2015 10:23:34 -0400
Received: from comal.ext.ti.com ([198.47.26.152]:41099 "EHLO comal.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932249AbbJ0OXc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 27 Oct 2015 10:23:32 -0400
Subject: Re: [PATCH v4 4/5] regulator: tps65912: Add regulator driver for the
 TPS65912 PMIC
To: Mark Brown <broonie@kernel.org>
References: <1443731874-21362-1-git-send-email-afd@ti.com>
 <1443731874-21362-5-git-send-email-afd@ti.com>
 <20151022164724.GZ8232@sirena.org.uk> <562A2C2F.1020808@ti.com>
 <20151023231822.GQ29919@sirena.org.uk> <562ACCCC.503@ti.com>
 <20151024221457.GS29919@sirena.org.uk> <562D3F77.5040205@ti.com>
 <20151026004320.GU29919@sirena.org.uk> <562E4B1D.4060205@ti.com>
 <20151027001608.GJ28319@sirena.org.uk>
CC: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Lee Jones <lee.jones@linaro.org>,
        Alexandre Courbot <gnurou@gmail.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: "Andrew F. Davis" <afd@ti.com>
Message-ID: <562F88D7.6030505@ti.com>
Date: Tue, 27 Oct 2015 09:23:19 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151027001608.GJ28319@sirena.org.uk>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/26/2015 07:16 PM, Mark Brown wrote:
> On Mon, Oct 26, 2015 at 10:47:41AM -0500, Andrew F. Davis wrote:
>> On 10/25/2015 07:43 PM, Mark Brown wrote:
>
>>>> .of_compatible = "mediatek,mt6397-regulator",
>
>>> This is in the MFD, this is not used in actual systems.
>
>> Not sure what you mean by "actual systems", it looks like these
>> use it?:
>
>> arch/arm/boot/dts/mt8135-evbp1.dts
>> arch/arm64/boot/dts/mediatek/mt8173-evb.dts
>
> To repeat: the regulator driver does not register a compatible string
> for the device for device model probing.
>
>> I understand this, I thought we are talking about compatible strings in
>> the regulator sub-node, not how the core instantiates the sub-driver.
>
> No, this exactly about how the device model devices are instantiated.
>

Ahh, I see, this makes more sense then, I'll re-spin this matching on
platform name.

Apologies about all this noise. :)