From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932642AbbJ0SwL (ORCPT ); Tue, 27 Oct 2015 14:52:11 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45168 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932359AbbJ0SwI (ORCPT ); Tue, 27 Oct 2015 14:52:08 -0400 Subject: Re: [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings To: ygardi@codeaurora.org References: <1445874072-25909-1-git-send-email-ygardi@codeaurora.org> <1445874072-25909-18-git-send-email-ygardi@codeaurora.org> <562EA19E.2070007@codeaurora.org> <723997f5afca9a1683db57b8ecb3cf44.squirrel@www.codeaurora.org> <562FB412.5050603@codeaurora.org> Cc: robherring2@gmail.com, james.bottomley@hansenpartnership.com, pebolle@tiscali.nl, hch@infradead.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org, gbroner@codeaurora.org, draviv@codeaurora.org, Vinayak Holikatti , "James E.J. Bottomley" From: Stephen Boyd Message-ID: <562FC7D5.8010606@codeaurora.org> Date: Tue, 27 Oct 2015 11:52:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/2015 11:22 AM, ygardi@codeaurora.org wrote: >> On 10/27/2015 03:10 AM, ygardi@codeaurora.org wrote: >>>> On 10/26/2015 08:41 AM, Yaniv Gardi wrote: >>>>> Tnis patch fixes the following compilation warnings: >>>>> ...ufs-qcom.c:1201:40: >>>>> warning: incorrect type in argument 1 (different address spaces) >>>>> ...ufs-qcom.c:1201:40: >>>>> expected void const *ptr >>>>> ...ufs-qcom.c:1201:40: >>>>> got void [noderef] *dev_ref_clk_ctrl_mmio >>>>> ...ufs-qcom.c:1207:53: >>>>> warning: incorrect type in argument 1 (different address spaces) >>>>> ...ufs-qcom.c:1207:53: >>>>> expected void const *ptr >>>>> ...ufs-qcom.c:1207:53: >>>>> got void [noderef] *dev_ref_clk_ctrl_mmio >>>>> >>>>> Signed-off-by: Yaniv Gardi >>>>> >>>>> --- >>>> What version of sparse do you use? You shouldn't need to do this. >>>> >>> i just updated my sparse to the newest - >>> so i'm using sparse 0.4.4 >>> and the command i use is: >>> make ARCH=arm C=1 CF="-Wsparse-all" >>> and i still get all the warnings. >>> with my patch, the are no warnings. >>> >> That is not the latest version of sparse. I'm not sure when sparse was >> updated, but I have the git version which shows v0.5.0-51-ga53cea28f0db >> > Stephen, is this something you insist on? > i think the patch can stay as it is. > please let me know, as i wouldn't like this issue to block the entire patch > Yes. Adding __force is wrong. Just drop this patch. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project