From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 629EEC433F5 for ; Sun, 23 Jan 2022 21:05:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240187AbiAWVFX (ORCPT ); Sun, 23 Jan 2022 16:05:23 -0500 Received: from mail.z3ntu.xyz ([128.199.32.197]:43316 "EHLO mail.z3ntu.xyz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231262AbiAWVFW (ORCPT ); Sun, 23 Jan 2022 16:05:22 -0500 Received: from g550jk.localnet (ip-213-127-106-2.ip.prioritytelecom.net [213.127.106.2]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id 79ED8CE792; Sun, 23 Jan 2022 21:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1642971921; bh=IepC/lcWLa4xj3rFu2AkdVzFzFWRURTPQvg3KPrFWsM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aW4eF76oHrvPRmzXRUKTyVUWIYBsZvhdMKp8LETBwcPilSAQ4/4ZS4TzpfJkNkdfT 7ok2QGSiAlqy3bEEpsqpUeFK6fqAEWx1YH/LQ41r98kNx2/3ZVG4HhrRTZ3WWsMynt CzhwNUGes4abuBlEIH/kYV9lQuZv7WM+SRNUJIjY= From: Luca Weiss To: dri-devel@lists.freedesktop.org Cc: ~postmarketos/upstreaming@lists.sr.ht, Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: add missing dependency to DRM_PANEL_EDP Date: Sun, 23 Jan 2022 22:05:21 +0100 Message-ID: <5630750.DvuYhMxLoT@g550jk> In-Reply-To: <20220123204322.345725-1-luca@z3ntu.xyz> References: <20220123204322.345725-1-luca@z3ntu.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sonntag, 23. J=E4nner 2022 21:43:23 CET Luca Weiss wrote: > With CONFIG_DRM_PANEL_EDP=3Dy and CONFIG_DRM_KMS_HELPER=3Dm the compilati= on > fails: >=20 > drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to > `drm_panel_dp_aux_backlight' >=20 > Add a dependency on DRM_KMS_HELPER to fix this. >=20 =46orgot to add, this is the closest "Fixes" I can find, before that commit= with=20 arm32 qcom_defconfig both beforementioned options were builtin =46ixes: 9d6366e743f3 ("drm: fb_helper: improve CONFIG_FB dependency") > Signed-off-by: Luca Weiss > --- > I briefly tried "select DRM_KMS_HELPER" but that causes a circular > dependency. > If someone has a better idea how to solve this, feel free correct me. >=20 > drivers/gpu/drm/panel/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 434c2861bb40..fda97837ecb3 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -102,6 +102,7 @@ config DRM_PANEL_SIMPLE > config DRM_PANEL_EDP > tristate "support for simple Embedded DisplayPort panels" > depends on OF > + depends on DRM_KMS_HELPER > depends on BACKLIGHT_CLASS_DEVICE > depends on PM > select VIDEOMODE_HELPERS