linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlos Bilbao <bilbao@vt.edu>
To: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Cc: andrew@lunn.ch
Subject: [PATCH] drivers: atm: Follow the indentation coding standard on printks
Date: Thu, 08 Jul 2021 11:19:19 -0400	[thread overview]
Message-ID: <5630870.MhkbZ0Pkbq@iron-maiden> (raw)
In-Reply-To: <YOcOWDqlONm69zwo@kroah.com>

Fix indentation of printks that start at the beginning of the line. Change this 
for the right number of space characters, or tabs if the file uses them. 

Signed-off-by: Carlos Bilbao <bilbao@vt.edu>
---
Changelog: Replaced printk for DPRINTK on suni.c
---
 drivers/atm/eni.c                      | 2 +-
 drivers/atm/iphase.c                   | 2 +-
 drivers/atm/suni.c                     | 4 ++--
 drivers/atm/zatm.c                     | 8 ++++----
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
index 422753d52244..6d10fd62ba7e 100644
--- a/drivers/atm/eni.c
+++ b/drivers/atm/eni.c
@@ -1456,7 +1456,7 @@ static int start_tx(struct atm_dev *dev)
 
 static void foo(void)
 {
-printk(KERN_INFO
+  printk(KERN_INFO
   "tx_complete=%d,dma_complete=%d,queued=%d,requeued=%d,sub=%d,\n"
   "backlogged=%d,rx_enqueued=%d,rx_dequeued=%d,putting=%d,pushed=%d\n",
   tx_complete,dma_complete,queued,requeued,submitted,backlogged,
diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index bc8e8d9f176b..65bb700cd5af 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -1246,7 +1246,7 @@ static void rx_intr(struct atm_dev *dev)
                ((iadev->rx_pkt_cnt - iadev->rx_tmp_cnt) == 0)) {
         for (i = 1; i <= iadev->num_rx_desc; i++)
                free_desc(dev, i);
-printk("Test logic RUN!!!!\n");
+        printk("Test logic RUN!!!!\n");
         writew( ~(RX_FREEQ_EMPT|RX_EXCP_RCVD),iadev->reass_reg+REASS_MASK_REG);
         iadev->rxing = 1;
      }
diff --git a/drivers/atm/suni.c b/drivers/atm/suni.c
index 21e5acc766b8..149605cdb859 100644
--- a/drivers/atm/suni.c
+++ b/drivers/atm/suni.c
@@ -328,8 +328,8 @@ static int suni_start(struct atm_dev *dev)
 		timer_setup(&poll_timer, suni_hz, 0);
 		poll_timer.expires = jiffies+HZ;
 #if 0
-printk(KERN_DEBUG "[u] p=0x%lx,n=0x%lx\n",(unsigned long) poll_timer.list.prev,
-    (unsigned long) poll_timer.list.next);
+	DPRINTK("[u] p=0x%lx,n=0x%lx\n",(unsigned long) poll_timer.list.prev,
+	    (unsigned long) poll_timer.list.next);
 #endif
 		add_timer(&poll_timer);
 	}
diff --git a/drivers/atm/zatm.c b/drivers/atm/zatm.c
index cf5fffcf98a1..4fb89ed47311 100644
--- a/drivers/atm/zatm.c
+++ b/drivers/atm/zatm.c
@@ -380,7 +380,7 @@ static void poll_rx(struct atm_dev *dev,int mbx)
 			pos = zatm_dev->mbx_start[mbx];
 		cells = here[0] & uPD98401_AAL5_SIZE;
 #if 0
-printk("RX IND: 0x%x, 0x%x, 0x%x, 0x%x\n",here[0],here[1],here[2],here[3]);
+		printk("RX IND: 0x%x, 0x%x, 0x%x, 0x%x\n",here[0],here[1],here[2],here[3]);
 {
 unsigned long *x;
 		printk("POOL: 0x%08x, 0x%08x\n",zpeekl(zatm_dev,
@@ -403,14 +403,14 @@ EVENT("error code 0x%x/0x%x\n",(here[3] & uPD98401_AAL5_ES) >>
 		skb = ((struct rx_buffer_head *) bus_to_virt(here[2]))->skb;
 		__net_timestamp(skb);
 #if 0
-printk("[-3..0] 0x%08lx 0x%08lx 0x%08lx 0x%08lx\n",((unsigned *) skb->data)[-3],
+		printk("[-3..0] 0x%08lx 0x%08lx 0x%08lx 0x%08lx\n",((unsigned *) skb->data)[-3],
   ((unsigned *) skb->data)[-2],((unsigned *) skb->data)[-1],
   ((unsigned *) skb->data)[0]);
 #endif
 		EVENT("skb 0x%lx, here 0x%lx\n",(unsigned long) skb,
 		    (unsigned long) here);
 #if 0
-printk("dummy: 0x%08lx, 0x%08lx\n",dummy[0],dummy[1]);
+		printk("dummy: 0x%08lx, 0x%08lx\n",dummy[0],dummy[1]);
 #endif
 		size = error ? 0 : ntohs(((__be16 *) skb->data)[cells*
 		    ATM_CELL_PAYLOAD/sizeof(u16)-3]);
@@ -664,7 +664,7 @@ static int do_tx(struct sk_buff *skb)
 		EVENT("dsc (0x%lx)\n",(unsigned long) dsc,0);
 	}
 	else {
-printk("NONONONOO!!!!\n");
+		printk("NONONONOO!!!!\n");
 		dsc = NULL;
 #if 0
 		u32 *put;
-- 
2.25.1




  reply	other threads:[~2021-07-08 15:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 13:10 [PATCH] drivers: " Carlos Bilbao
2021-07-08 14:40 ` Greg KH
2021-07-08 15:19   ` Carlos Bilbao [this message]
2021-07-08 15:48     ` [PATCH] drivers: atm: " Andrew Lunn
2021-07-08 17:06       ` Carlos Bilbao
2021-07-08 17:23         ` [PATCH net-next v2] " Carlos Bilbao
2021-07-08 17:27       ` Carlos Bilbao
2021-07-08 18:15         ` Andrew Lunn
2021-07-08 14:53 ` [PATCH] drivers: " Andrew Lunn
2021-07-08 15:08   ` Carlos Bilbao
2021-07-08 21:25 ` Rolf Eike Beer
2021-07-09  0:27   ` Stephen Hemminger
2021-07-09  6:43   ` Helge Deller
2021-07-09 10:30     ` bilbao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5630870.MhkbZ0Pkbq@iron-maiden \
    --to=bilbao@vt.edu \
    --cc=3chas3@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] drivers: atm: Follow the indentation coding standard on printks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).