From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755871AbbJ1K4J (ORCPT ); Wed, 28 Oct 2015 06:56:09 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:26180 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754723AbbJ1K4F (ORCPT ); Wed, 28 Oct 2015 06:56:05 -0400 X-AuditID: cbfec7f5-f794b6d000001495-9a-5630a9c20778 Message-id: <5630A9C1.5060907@samsung.com> Date: Wed, 28 Oct 2015 11:56:01 +0100 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Simon Arlott Cc: Richard Purdie , linux-leds@vger.kernel.org, Linux Kernel Mailing List , =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= , Jonas Gorski Subject: Re: [PATCH] leds: bcm6328: Handle default-state of LEDs correctly References: <562BB799.7000708@simon.arlott.org.uk> <562DE832.6070903@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xq7qHVhqEGZyfq2pxe90pNovLu+aw WWx9s47RYs2dQ6wWu3c9ZbW4cP4zswObx+L+JYweO2fdZffYsjjDY8/8H6wenzfJBbBGcdmk pOZklqUW6dslcGXMX3GZvWAaW8XjS93sDYx/WboYOTkkBEwk+ve8YoKwxSQu3FvP1sXIxSEk sJRR4sGce1DOM0aJ/m/H2ECqeAW0JK7MXsgMYrMIqEq8fvueHcRmEzCU+PniNdgkUYEIiT+n 97FC1AtK/Jh8D2ybiICKxIVb7awgQ5kFnjJKbL78HaxIWMBL4tvuVhaIbRsZJb7fvwa2jVMg S2JOz0VGEJtZwEziUcs6ZghbXmLzmrfMExgFZiFZMgtJ2SwkZQsYmVcxiqaWJhcUJ6XnGukV J+YWl+al6yXn525ihIT31x2MS49ZHWIU4GBU4uE1qNALE2JNLCuuzD3EKMHBrCTC+63FIEyI NyWxsiq1KD++qDQntfgQozQHi5I478xd70OEBNITS1KzU1MLUotgskwcnFINjBk7u+Y9UXUw 0114MFz7S+Bt+0aL20t3WXBy63RfEpd05uyR/mvEc6R98/97+879urb97p3XluJJVj/NC+Pf xC7oO+osyLrTZ6fe0SxH54R6DrGwTwbXLEq3hrImlU//qeebbrNf0fCY0KetiSWO95yWTJxu /v7kSa+zMnuVb3fce97/dpL1HyWW4oxEQy3mouJEAAjK6bBrAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Simon, On 10/26/2015 01:36 PM, Simon Arlott wrote: > On Mon, October 26, 2015 08:45, Jacek Anaszewski wrote: >> Hi Simon, >> >> Thanks for the patch. There are conflicts when applying >> it to the LED tree: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git >> >> Please use it as a code base for your LED development. > > This has already been fixed in the devel branch by d19e6b6a0062c86a75365f0715fd079245f6aab9, > although I think bcm6328_led() should adjust its use of the spinlock > to only cover reading the register and call bcm6328_led_set() instead > of copying the code from it. > It is also on the for-next branch. Feel free to submit the patch, if you see the room for improvement. -- Best Regards, Jacek Anaszewski