From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756841AbbJ2Iex (ORCPT ); Thu, 29 Oct 2015 04:34:53 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:31491 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbbJ2Iev (ORCPT ); Thu, 29 Oct 2015 04:34:51 -0400 Subject: Re: [PATCH V5 Base on RC7 3/3] Add reset controller for hi6220 SoC platform. To: Philipp Zabel References: <1445939498-94147-1-git-send-email-puck.chen@hisilicon.com> <1445939498-94147-3-git-send-email-puck.chen@hisilicon.com> <1446032542.12590.33.camel@pengutronix.de> CC: , , , , From: chenfeng Message-ID: <5631DA1F.2090109@hisilicon.com> Date: Thu, 29 Oct 2015 16:34:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1446032542.12590.33.camel@pengutronix.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.192.172] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks. On 2015/10/28 19:42, Philipp Zabel wrote: > Am Dienstag, den 27.10.2015, 17:51 +0800 schrieb Chen Feng: >> reset: add driver for hi6220 reset controller >> >> Signed-off-by: Chen Feng >> --- >> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> index 3f03380..3f055e2 100644 >> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> @@ -167,5 +167,12 @@ >> clocks = <&ao_ctrl 36>, <&ao_ctrl 36>; >> clock-names = "uartclk", "apb_pclk"; >> }; >> + >> + reset_ctrl: reset_ctrl@f7030000 { >> + compatible = "hisilicon,hi6220-reset-ctl"; >> + reg = <0x0 0xf7030000 0x0 0x1000>; >> + #reset-cells = <1>; >> + }; >> + > > While applying I just noticed that the device tree already contains a > node claiming the same address space: > > sys_ctrl: sys_ctrl@f7030000 { > compatible = "hisilicon,hi6220-sysctrl", "syscon"; > reg = <0x0 0xf7030000 0x0 0x2000>; > #clock-cells = <1>; > }; > > It is documented in > Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt and > Documentation/devicetree/bindings/clock/hi6220-clock.txt. > > Could you clarify whether the reset controls are just part of the > sys_ctrl block? If so, I think you should add #reset-cells = <1> to the > sys_ctrl node instead. > Yes, It's a part of the sys_ctrl block, I will do as your advice. > regards > Philipp > > > . >