From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757226AbbJ2U2K (ORCPT ); Thu, 29 Oct 2015 16:28:10 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33593 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754006AbbJ2U2H (ORCPT ); Thu, 29 Oct 2015 16:28:07 -0400 Subject: Re: [PATCH v2] blktrace: re-write setting q->blk_trace To: Davidlohr Bueso , Jeff Moyer References: <20151027030545.GH27292@linux-uzut.site> <20151027031452.GI27292@linux-uzut.site> <20151029191905.GA7947@linux-uzut.site> Cc: Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org From: Jens Axboe Message-ID: <56328152.9040001@kernel.dk> Date: Fri, 30 Oct 2015 05:28:02 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151029191905.GA7947@linux-uzut.site> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/2015 04:19 AM, Davidlohr Bueso wrote: > >> The patch itself looks ok, but it doesn't seem to apply to a recent >> kernel tree. It appears as though it is white-space damaged. Would you >> mind re-sending it? > > Hmm sorry about that. I thought I had based it against that day's > tip/master. > Anyway, here is v3 which is against tip/master as of > 338e29ba93639138fafb9fb5ba946fd99a512aae. Thanks, this is definitely cleaner. Your patch is still pretty mangled, though. I had to hand apply it. Please check the result: http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.4/core&id=cdea01b2bf98affb7e9c44530108a4a28535eee8 -- Jens Axboe