From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030589AbbJ3Iih (ORCPT ); Fri, 30 Oct 2015 04:38:37 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:53880 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966062AbbJ3IiK (ORCPT ); Fri, 30 Oct 2015 04:38:10 -0400 X-AuditID: cbfec7f5-f794b6d000001495-5c-56332c6fb801 Subject: Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC To: Alim Akhtar , lee.jones@linaro.org, broonie@kernel.org References: <1446186334-16510-1-git-send-email-alim.akhtar@samsung.com> <1446186334-16510-5-git-send-email-alim.akhtar@samsung.com> Cc: linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Alexandre Belloni From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56332C69.1050608@samsung.com> Date: Fri, 30 Oct 2015 17:38:01 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1446186334-16510-5-git-send-email-alim.akhtar@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPLMWRmVeSWpSXmKPExsVy+t/xa7r5OsZhBqtO6Vp0XFvMZPFg3jY2 i6kPn7BZvH5haHH/61FGi8u75rBZzDi/j8lif2cHowOHx5NNFxk99kw8yeaxaVUnm8eda3vY PPq2rGL0+LxJLoAtissmJTUnsyy1SN8ugSvjTfd99oI9nBWHdp9kaWDcwN7FyMkhIWAiMevO DiYIW0ziwr31bCC2kMBSRonv9zW6GLmA7C+MEj9PvANKcHAIC/hJNN1OAakREQiVmDH/ATNE TSujxJFrrawgDrPAXEaJF9t/MIJUsQkYS2xevoQNYoOcRG/3JBYQm1dAS2LljN3MIDaLgKrE tglvweKiAhESEyc0sELUCEr8mHwPLM4p4CFxc+NPsCOYBfQk7l/UAgkzC8hLbF7zlnkCo+As JB2zEKpmIalawMi8ilE0tTS5oDgpPddIrzgxt7g0L10vOT93EyMkGr7uYFx6zOoQowAHoxIP 748EozAh1sSy4srcQ4wSHMxKIrzvFIzDhHhTEiurUovy44tKc1KLDzFKc7AoifPO3PU+REgg PbEkNTs1tSC1CCbLxMEp1cC46edDjT3BFZIFO63WC8a3sl17WtcV//qUkFCn5rWYvYYVvwSz Ne0cM6/yPFURXxplkqGS0p2e2Ox4pmP5zajD1pNuFrrqy71LD4tqPPLiTtQ31pge7mV1p1Yd ub2w+07srqsGDYmZJQ9N66wet54Sbfh9VdJYYo2/bt8MltnpRsqv7knfvKnEUpyRaKjFXFSc CAD1AnIkggIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.10.2015 15:25, Alim Akhtar wrote: > RTC found in s2mps15 is almost same as one found on s2mps13 > with few differences in RTC_UPDATE register fields, like: > 1> Bit[4] and Bit[1] are reversed > - On s2mps13 > WUDR -> bit[4], AUDR -> bit[1] > - On s2mps15 > WUDR -> bit[1], AUDR -> bit[4] > 2> In case of s2mps13, for alarm register, need to set both > WDUR and ADUR high, whereas for s2mps15 only set AUDR to high. > 3> On s2mps15, WUDR, RUDR and AUDR functions should never be used > at the same time. > > This patch add required changes to enable s2mps15 rtc timer. > > Cc: Alexandre Belloni > Signed-off-by: Alim Akhtar > --- > drivers/rtc/rtc-s5m.c | 37 +++++++++++++++++++++++++++++++++---- > include/linux/mfd/samsung/rtc.h | 2 ++ > 2 files changed, 35 insertions(+), 4 deletions(-) > The usage of rtc_udr_mask is now a little bit messy and not-consistent but this can be fixed in separate patch. Current approach is the simplest way to add S2MPS15 and looks correct: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof