From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759536AbbJ3J1U (ORCPT ); Fri, 30 Oct 2015 05:27:20 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:37961 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759152AbbJ3J1R (ORCPT ); Fri, 30 Oct 2015 05:27:17 -0400 X-AuditID: cbfee68f-f796f6d0000014a4-e6-563337f3fe49 Message-id: <5633382F.4000300@samsung.com> Date: Fri, 30 Oct 2015 14:58:15 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski , lee.jones@linaro.org, broonie@kernel.org Cc: linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Alexandre Belloni Subject: Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC References: <1446186334-16510-1-git-send-email-alim.akhtar@samsung.com> <1446186334-16510-5-git-send-email-alim.akhtar@samsung.com> <56332C69.1050608@samsung.com> In-reply-to: <56332C69.1050608@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsWyRsSkWvezuXGYwbfPOhYd1xYzWUx9+ITN 4vULQ4v7X48yWlzeNYfNYsb5fUwW+zs7GB3YPZ5susjosWfiSTaPTas62TzuXNvD5tG3ZRWj x+dNcgFsUVw2Kak5mWWpRfp2CVwZO67eZC3Yw1XxbdsllgbGiRxdjJwcEgImEn9ffmaHsMUk LtxbzwZiCwmsYJT4OE8KpuZZUxtQDRdQfCmjxJrXN9ggnAeMElMnTQfr4BXQknjbeY8ZxGYR UJX4e/ICC4jNJqAtcXf6FqYuRg4OUYEIiccXhCDKBSV+TL7HAhIWEYiV+PVFB2Qks8BcRokX 238wgsSFBfwkmm6nQKxaxigx/8EDsEM5gUY2Nj9gArGZBWwlFrxfxwJhy0tsXvOWGaRBQuAW u0THq6nsEPcISHybfAhsmYSArMSmA8wQj0lKHFxxg2UCo9gsJCfNQjJ2FpKxCxiZVzGKphYk FxQnpRcZ6xUn5haX5qXrJefnbmIERt/pf8/6dzDePWB9iFGAg1GJhzcg2ShMiDWxrLgy9xCj KdAVE5mlRJPzgTGeVxJvaGxmZGFqYmpsZG5ppiTOu1DqZ7CQQHpiSWp2ampBalF8UWlOavEh RiYOTqkGRou2CYkK++KfZD/sUvB9NLHJLU7GK3uiSNn+ApkZ9gGz66YKWikUX3ITF/7eazTp vo5x0RzhOXOSbmTNey6pcEqh+kv9oQ9JBd/Wng3klTJ+ee7RB2VRjxn1gQmG27dwMJ+d1vbm fRnTKr5F9nt2H3sZ6bf7ZseEI09YKyIun/5mwHmybsPPBCWW4oxEQy3mouJEAGzk7JC5AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsVy+t9jAd3P5sZhBrduqVl0XFvMZDH14RM2 i9cvDC3ufz3KaHF51xw2ixnn9zFZ7O/sYHRg93iy6SKjx56JJ9k8Nq3qZPO4c20Pm0ffllWM Hp83yQWwRTUw2mSkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6 ZeYA3aKkUJaYUwoUCkgsLlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxhzNhx9SZrwR6uim/b LrE0ME7k6GLk5JAQMJF41tTGDmGLSVy4t56ti5GLQ0hgKaPEmtc3oJwHjBJTJ01nA6niFdCS eNt5jxnEZhFQlfh78gILiM0moC1xd/oWpi5GDg5RgQiJxxeEIMoFJX5MvscCEhYRiJX49UUH ZCSzwFxGiRfbfzCCxIUF/CSabqdArFrGKDH/wQOwgziBRjY2P2ACsZkFbCUWvF/HAmHLS2xe 85Z5AqPALCQrZiEpm4WkbAEj8ypGidSC5ILipPRco7zUcr3ixNzi0rx0veT83E2M4Bh/Jr2D 8fAu90OMAhyMSjy8AclGYUKsiWXFlbmHGCU4mJVEeN8pGIcJ8aYkVlalFuXHF5XmpBYfYjQF hsFEZinR5Hxg+skriTc0NjE3NTa1NLEwMbNUEufV9wSaI5CeWJKanZpakFoE08fEwSnVwHio QebGovLkpGkahh15Lr1PjgQlTJwZEFKSZ1W/rm9DTZrefIsUl2ZP0aeGxX5Wa4qUAi8mb56k 0BAs+nD3Mp3f4rcNFx5pXfOMXe3N2p0fhfOYt810mSyc++au07bWWUvYFi7e8XYVx5fk60tX njjdyPRz/vu12yc+sWdyOnylIXoRR4dv4ywlluKMREMt5qLiRAD5VGQeBwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 10/30/2015 02:08 PM, Krzysztof Kozlowski wrote: > On 30.10.2015 15:25, Alim Akhtar wrote: >> RTC found in s2mps15 is almost same as one found on s2mps13 >> with few differences in RTC_UPDATE register fields, like: >> 1> Bit[4] and Bit[1] are reversed >> - On s2mps13 >> WUDR -> bit[4], AUDR -> bit[1] >> - On s2mps15 >> WUDR -> bit[1], AUDR -> bit[4] >> 2> In case of s2mps13, for alarm register, need to set both >> WDUR and ADUR high, whereas for s2mps15 only set AUDR to high. >> 3> On s2mps15, WUDR, RUDR and AUDR functions should never be used >> at the same time. >> >> This patch add required changes to enable s2mps15 rtc timer. >> >> Cc: Alexandre Belloni >> Signed-off-by: Alim Akhtar >> --- >> drivers/rtc/rtc-s5m.c | 37 +++++++++++++++++++++++++++++++++---- >> include/linux/mfd/samsung/rtc.h | 2 ++ >> 2 files changed, 35 insertions(+), 4 deletions(-) >> > > The usage of rtc_udr_mask is now a little bit messy and not-consistent > but this can be fixed in separate patch. > > Current approach is the simplest way to add S2MPS15 and looks correct: > > Reviewed-by: Krzysztof Kozlowski > Thanks! > Best regards, > Krzysztof > >