From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
"moderated list:H8/300 ARCHITECTURE"
<uclinux-h8-devel@lists.sourceforge.jp>
Subject: Re: [PATCH] Revert "h8300: clocksource"
Date: Fri, 30 Oct 2015 12:48:52 +0100 [thread overview]
Message-ID: <56335924.408@linaro.org> (raw)
In-Reply-To: <7633294.svub55eV7t@wuerfel>
On 10/30/2015 12:19 PM, Arnd Bergmann wrote:
> On Friday 30 October 2015 11:26:08 Daniel Lezcano wrote:
>> This reverts commit 618b902d8c098f2fff188119da7b3184c4bc5483.
[ ... ]
> I found that Yoshinori Sato has always addressed all review comments very
> quickly by rewriting the code in a proper manner when mistakes were
> pointed out in the other drivers. Maybe you can describe now what the
> problems are with the three drivers to give him a chance to fix them?
I agree it is a good argument to give him the opportunity to fix the code.
Yoshinori Sato, can you please do a cleanup in the init functions to
comply with the other drivers, use CLOCKSOURCE_OF_DECLARE and remove the
module exit code ?
Thanks.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-10-30 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 10:26 [PATCH] Revert "h8300: clocksource" Daniel Lezcano
2015-10-30 11:19 ` Arnd Bergmann
2015-10-30 11:48 ` Daniel Lezcano [this message]
2015-10-31 4:13 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56335924.408@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).